pcb

  1. Bug #1308929
  2. Comment #2

Comment 2 for bug 1308929

Revision history for this message
Traumflug (mah-jump-ing) wrote :

Looking at the code, I don't think removing the outer condition is the right choice. There are several inner conditions and some code without additional condition, which all gets executed unconditionally, then.

A few additional points:

- I've looked up GTS (http://gts.sourceforge.net/), the last release was in 2006, while it was imported to pcb in 2009. Upgrading to the latest GTS is obviously not an option, it is the latest version already.

- As far as I can see, GTS was imported for the Toporouter, and only to get Delaunay triangulations. Toporouter is 2D, while GTS has 3D in mind. It's a rather heavyweight choice.

- Not sure how @dcb made it, but here GTS compiles warning free, with or without the patch.

- It should be an option to remove GTS from pcb entirely and rely on the external package instead. Package name in Debian/Ubuntu is 'libgts-0.7' (runtime) or 'libgts-dev' (build time).