pcb

Comment 8 for bug 1022076

Revision history for this message
Bert Timmerman (bert-timmerman) wrote :

Hi Traumflug,

About commit dc7454e1c8c06f4bb4255acd423da41beb0180fa in topic branch "LP1022076v2": testing is a Good Thing (TM).

However, if you add a testfile for testing against regression (I see a pcb file added in "./tests/input"), then there also needs to be a test (to be executed by invoking "./run_tests.sh" in the directory "./tests") available.

Could you please add a command in "./tests/tests.list" for testing with the hid of your choice (I think Gcode or gerber are good candidates) and add a "golden" file too (the file with correct output to test against ;-) .

And please change the added filename into <hid name>_minmaskgap.pcb.

Kind regards,

Bert Timmerman.