Comment 5 for bug 1022076

On 08/23/2015 11:08 PM, Traumflug wrote:
> Took a look at this.
>
> The patch has no effect here. Reason is, drilling holes are usually vias
> with the "hole" flag, but the patch acts on Pins, only.

You obviously forgot about holes *in Element[]s*. These are *pins*
with the hole flag set. My tiny patch just fixes an obvious issue.
This is the exact kind of bikeshed discussions that remind me that
forking pcb some time ago was a good idea.

> Also, vias are
> usually fully covered with solder resist, no hole in the mask at all.

Many of the very big fab houses require vias to be *not covered* with
solder mask, Würth Elektronik for example.

> As
> no sample was provided I'll have to make a hand-edited one.
>
> I think this whould be a reasonable solution:
>
> - Handle vias and pins the same regarding solder mask.
>
> - Increase mask hole only if it was > zero before. Currently vias are
> handled this way.
>
> - Take for both the bigger of thickness and drill hole as reference for
> gap calculation.
>