pcb

Comment 12 for bug 1005644

Revision history for this message
Peter Clifton (pcjc2) wrote :

Implementation comments...

I'd prefer to avoid using the vector_ APIs, as the code underneath is pretty dated (and by the feel of it, due being killed with fire). It is currently only used (as far as I can see) by the autorouter.

As we now depend on glib, and you can have GLists and other nice functionality from there at will. If I get time, I'll look at whether there is a case for migrating some of the users of the old vector_ code to something like that.

I've not reviewed the code in huge detail, but a cursory glance suggests that certain parts might be much simplified with a few of the nicer GLib string handling routines. (g_strdup_printf() is a lovely function to avoid lot of strlen calls and memory allocation grief).

Regards,

Peter Clifton