PBR

Comment 2 for bug 1300381

Revision history for this message
Sam Stavinoha (smlstvnh) wrote :

I have seen various threads on extending setuptools command classes...

http://stackoverflow.com/questions/15853058/run-custom-task-when-call-pip-install
http://stackoverflow.com/questions/17806485/execute-a-python-script-post-install-using-distutils-setuptools
http://www.niteoweb.com/blog/setuptools-run-custom-code-during-install

but for me it was to add user_options and execute additional tasks based on those options. e.g. installing an additional package for a tag like --with-redis, where in my code I try, except imports when constructing the database client instance.

Regarding this bug:

The only time this occurs is if a command class is specified for which pbr has a corresponding command class (has the same `command_name`). I created custom classes for 'develop' and 'install', but only the class I created for 'install' was being overwritten, which I thought was pretty odd behavior.

I have other packages using this type of setup for custom command classes, and no matter the purpose of the customization, I would really like to start using pbr on all of those projects, but this prevents me from doing so.

I went ahead and submitted a patch just in case:

https://review.openstack.org/#/c/84218/