Move config drive tests into misc policy actions file
This commit does 3 things:
1a) Corrects the "config_drive" tests by aligning the
tests with the nova policy documentation [0] which
states that "config_drive" is to added the response
body of showing a server or listing servers with details
if policy enforcement passes.
1b) Consequently, 2 tests are added: 1 for show and 1 for
list with details.
2) Moves both tests into the misc policy actions file to
increase gate stability and decrease gate run time.
The number of calls to create_test_server() should be minimized
for RBAC testing because we don't do too much modification to the
resources that are created -- only what's necessary to trigger the
API action corresponding to the RBAC policy under test. Further,
minimizing such calls reduces the risk of spinning up too many servers
concurrently in our gates: the source of various gate failures as
limited resources lead to server faults being raised.
Reviewed: https:/ /review. openstack. org/484215 /git.openstack. org/cgit/ openstack/ patrole/ commit/ ?id=6c068fcbbed 3d148b4f79464bd afac08650e42ab
Committed: https:/
Submitter: Jenkins
Branch: master
commit 6c068fcbbed3d14 8b4f79464bdafac 08650e42ab
Author: Felipe Monteiro <email address hidden>
Date: Mon Jul 17 00:13:21 2017 +0100
Move config drive tests into misc policy actions file
This commit does 3 things:
1a) Corrects the "config_drive" tests by aligning the
tests with the nova policy documentation [0] which
states that "config_drive" is to added the response
body of showing a server or listing servers with details
if policy enforcement passes.
1b) Consequently, 2 tests are added: 1 for show and 1 for
list with details.
2) Moves both tests into the misc policy actions file to
increase gate stability and decrease gate run time.
The number of calls to create_ test_server( ) should be minimized
for RBAC testing because we don't do too much modification to the
resources that are created -- only what's necessary to trigger the
API action corresponding to the RBAC policy under test. Further,
minimizing such calls reduces the risk of spinning up too many servers
concurrently in our gates: the source of various gate failures as
limited resources lead to server faults being raised.
[0] https:/ /github. com/openstack/ nova/blob/ master/ nova/policies/ config_ drive.py
Change-Id: If54fce795c2289 b097b617cad7268 dc9a3d9cf1c
Partial-Bug: #1699415