Panda3D

  1. Bug #784923
  2. Comment #2

Comment 2 for bug 784923

Revision history for this message
zhao (oahz12) wrote : Re: [Bug 784923] Re: dx9 multisample refresh rate lock

Hi david, you're completely right. (This should be on line 771 by the way,
not 711 as in the bug report)

      if (do_sync == false) {
        presentation_params->SwapEffect = D3DSWAPEFFECT_FLIP;
        presentation_params->PresentationInterval =
D3DPRESENT_INTERVAL_IMMEDIATE;
      }
      presentation_params->SwapEffect = D3DSWAPEFFECT_DISCARD;

there should an else or the order of the two swapped in my earlier proposal.
I think I was blinded by the redundant if
statement in the earlier block and wasn't thinking clearly.

Unfortunately, when i was testing, the line

 presentation_params->PresentationInterval = D3DPRESENT_INTERVAL_IMMEDIATE;

had the most effect and masked out my carelesness. Thanks for catching it!