Comment 0 for bug 1426567

Revision history for this message
Chris Coulson (chrisccoulson) wrote : Support pinch-viewport and overlay scrollbars on desktop

A change I'm about to push in order to finally get correctly behaving scrollbars on the device breaks overlay scrollbars and pinch-viewport on desktop, so I've reported this to do extra work later on to make them both work.

- The overlay scrollbar thumb style is defined in third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.cpp to be 10DIPs wide, hit-tested and no margin. I've modified this to be 3DIPs wide with a 3DIP margin and no hit-testing, which is great for the device but sucks on desktop.

- I've modified third_party/WebKit/Source/core/frame/FrameView.cpp to disable scrollbars for the main frame when pinch-viewport is enabled, as we display the pinch-viewport scrollbars all the time because these are the ones that stick to the device viewport (the same as Chrome on Android). Chrome on the desktop still displays non-overlay scrollbars attached to the outer viewport for the main-frame, and then displays the pinch-viewport overlay scrollbars (attached to the device viewport) during pinch, but Oxide would need additional work to support both of these.