Comment 1 for bug 1290821

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

The issue here is that the signal we use for notifying of changes to WebView.loading (WebView.loadingChanged) comes from the wrong source. With hindsight, it would have been better to have 2 separate signals (one for notifying of changes to WebView.loading, and another one to deliver LoadEvents).

I think the way to fix this is to split the existing signal in 2:

- Introduce WebView.loadingStateChanged to notify of changes to WebView.loading.
- Introduce WebView.loadEvent for delivering LoadEvent's

The existing WebView.loadingChanged will be kept around, so applications that do "onLoadingChanged {}" or "WebView.loadingChanged.connect()" will continue to work exactly the same (albeit, with this bug)