commit 315c8096c9bb3ad6d09e3b2f09bc1c128bc35497
Author: Terry Wilson <email address hidden>
Date: Thu Sep 1 09:48:38 2022 -0500
Fix TRY_AGAIN handling
I believe removing wait_for_change back in the day was an error.
We can't do the exponential backoff ourselves because that will
also delay reconnecting to the the db, because idl.run() needs to
be called. Also, do_commit() doesn't ensure that idl.run() is
called if status is TRY_AGAIN. wait_for_change() will ensure that
we call idl.run() to reconnect quickly and don't try the txn again
until we have reconnected and the seqno has changed.
Revert "Don't spam retries 100s of times a second"
This reverts commit 6596164f51217cc7fabf302ce14ccc9d9beaff1f.
Revert "Ensure idl.run() called on TRY_AGAIN"
This reverts commit 1810faecc9ad2345f3e2f9185ac64194c5a0d711.
Revert "Don't wait on TRY_AGAIN when calling commit_block()"
This reverts commit 158ae06bce0f56e93677f94c59f81e5e76ee1ccc.
Closes-Bug: #1988457
Change-Id: I237136262862d5117d08eb3b513a0b8658a79f05
(cherry picked from commit c3bacb3ba37e2824920ac79766205a3b51ab12d5)
Reviewed: https:/ /review. opendev. org/c/openstack /ovsdbapp/ +/856198 /opendev. org/openstack/ ovsdbapp/ commit/ 315c8096c9bb3ad 6d09e3b2f09bc1c 128bc35497
Committed: https:/
Submitter: "Zuul (22348)"
Branch: stable/yoga
commit 315c8096c9bb3ad 6d09e3b2f09bc1c 128bc35497
Author: Terry Wilson <email address hidden>
Date: Thu Sep 1 09:48:38 2022 -0500
Fix TRY_AGAIN handling
I believe removing wait_for_change back in the day was an error.
We can't do the exponential backoff ourselves because that will
also delay reconnecting to the the db, because idl.run() needs to
be called. Also, do_commit() doesn't ensure that idl.run() is
called if status is TRY_AGAIN. wait_for_change() will ensure that
we call idl.run() to reconnect quickly and don't try the txn again
until we have reconnected and the seqno has changed.
Revert "Don't spam retries 100s of times a second" 7fabf302ce14ccc 9d9beaff1f.
This reverts commit 6596164f51217cc
Revert "Ensure idl.run() called on TRY_AGAIN" 5f3e2f9185ac641 94c5a0d711.
This reverts commit 1810faecc9ad234
Revert "Don't wait on TRY_AGAIN when calling commit_block()" 93677f94c59f81e 5e76ee1ccc.
This reverts commit 158ae06bce0f56e
Closes-Bug: #1988457 117d08eb3b513a0 b8658a79f05 4920ac79766205a 3b51ab12d5)
Change-Id: I237136262862d5
(cherry picked from commit c3bacb3ba37e282