Comment 6 for bug 2017886

I don't think this is working. When I configure a router with SNAT disabled, the exposing of the subnet that connected southbound of the router is not being exposed correctly.

Here is what I observe:

Route added to br-ex connecting my subnet (192.168.0.0/24) via the router gateway (10.0.0.10). Redistribute kernel is enabled, yet there are no routes in the FRR routing table being announced.

I believe for SNAT disabled, we need to be wiring the subnet's port (192.168.0.1/24) up so that we can see a route in FRR for 192.168.0.0/24 as directly connected.

In the code, I see that we detect 192.168.0.1/24 and convert it to 192.168.0.0/24 so it can have a route added with a next hop being the router gateway. For disabled SNAT I believe this to be wrong, as the purpose of a disabled SNAT is to eliminate that next hop.

What I believe we should be doing, is make the subnet's gateway (192.168.0.1/24) appear as directly connected. This will allow the 192.168.0.0/24 route to be announced via BGP.