Comment 1 for bug 301167

Revision history for this message
Mark Atwood (fallenpegasus) wrote :

This patch needs two more things to be production ready.

The memcached server specification needs to be a configvar instead of compiled in.

The memcache key needs to have a unique-per-run id encoded into it, so that when mysqld is restarted without restarting the memcached servers, it doesnt try to pick up stale cached data, and get corrupted.

It would be good to insert the block id's being cached into a bloom filter. That way it can check the bloom filter before checking the memcached, and thus the cost of cache misses will go way down.

A nice-to-have would be to add cache hit and cache miss counters, and display them as statistics.