I can confirm the issue as well. I've enabled cleaning and the clean step was just skipped.
I also can confirm that if I apply the patch and only enable the "erase_devices" clean step this works as expected.
However, I wanted to test some different scenarios with in-band and out-of-band cleaning steps and cleaning seems to be stuck when there's more than one clean step enabled after I applied the patch. I've created a very simple clean step that all it does is to create a file under "/tmp" in the RAID interface for the agent_ssh driver (that interface is enabled by default for that driver). So when I run, I can see cleaning being executed and then once it moves to the new step Ironic executes it (I can see the file under /tmp) but Ironic never finishes the clean process, here's the current output of node-show and the file created [1].
And here's the diff of the @Jim's patch applied + the new in-band clean step [2]
Hi,
I can confirm the issue as well. I've enabled cleaning and the clean step was just skipped.
I also can confirm that if I apply the patch and only enable the "erase_devices" clean step this works as expected.
However, I wanted to test some different scenarios with in-band and out-of-band cleaning steps and cleaning seems to be stuck when there's more than one clean step enabled after I applied the patch. I've created a very simple clean step that all it does is to create a file under "/tmp" in the RAID interface for the agent_ssh driver (that interface is enabled by default for that driver). So when I run, I can see cleaning being executed and then once it moves to the new step Ironic executes it (I can see the file under /tmp) but Ironic never finishes the clean process, here's the current output of node-show and the file created [1].
And here's the diff of the @Jim's patch applied + the new in-band clean step [2]
[1] http:// fpaste. org/292697/ 48015718/ (password: ironic123)
[2] http:// fpaste. org/292695/ 01541214/ (password: ironic123)
@Deva, @Jim, can you guys confirm if the patch works when there's more than one clean step enabled?