Comment 27 for bug 1354208

Revision history for this message
Brant Knudson (blk-u) wrote : Re: Catalog replacement allows reading config

Tried out the patches in 23-25 and they all worked for me.

master:

- tox py27,pep8
-- passed

- visual inspection

I'd prefer it if tenant_id and user_id weren't in the whitelist config option but were always allowed. These are values set by keystone and not from the config file, so the help text is kind of confusing (it says the values are in the config file) and a user might think they can remove those values, but it's probably going to break just about every deployment if they do.

I'm also fine with the change as is.

- try it
-- Worked... no endpoint.

stable/icehouse:

- tox py27,pep8
-- passed

- visual inspection
-- LGTM

- try it
-- worked, got 500 error

stable/havana:

- tox py27,pep8

- visual inspection
-- LGTM

- try it
-- 500 error