OpenStack Security Advisory

  1. Bug #1350504
  2. Comment #31

Comment 31 for bug 1350504

Revision history for this message
Lucian Petrut (petrutlucian94) wrote : Re: GlusterFS driver uses unsafe qcow2 format detection

Can you please change this in the Windows SMB driver as well? The only thing that needs to be done is updating the _qemu_img_info method, adding the volume_name parameter defaulting to None, so that this patch won't break it.

https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/windows/smbfs.py#L138

The idea is that this driver does not use qemu-img actually (among others, it can not open in-use images on Windows, so it's using the Win32 API instead ATM) so the method is there for consistency.

Note that for the moment, only vhd/vhdx images are supported by this driver, so it is not exposed to the above mentioned security issue.