Comment 15 for bug 1735588

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova (master)

Reviewed: https://review.openstack.org/538022
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9c7d6123e3e66fd8b182af548273df9e7d66ee36
Submitter: Zuul
Branch: master

commit 9c7d6123e3e66fd8b182af548273df9e7d66ee36
Author: Claudiu Belu <email address hidden>
Date: Wed Jan 24 23:30:37 2018 -0800

    tests: refactors and cleans up test_rbd.py

    In the unit tests' setUp, it was setting self.mock_rbd = mock_rbd
    (where mock_rbd is the argument passed by @mock.patch.object) and
    setting all sorts of properties onto self.mock_rbd, but mock_rbd
    would become invalid after setUp finished, as the mock.patch
    decorator would remove the patched mock. The same applies with
    mock_rados.

    This patch addresses this issue by refactoring and simplifying the
    unit tests.

    Change-Id: Ie2bf4d559e5391be3fe778835673a11de7ec8e1b
    Related-Bug: #1735588