Comment 11 for bug 1482382

Reviewed: https://review.openstack.org/537823
Committed: https://git.openstack.org/cgit/openstack/oslo.concurrency/commit/?id=21ae27e66d77f276c23a7ca2eaa8869438fb4d31
Submitter: Zuul
Branch: master

commit 21ae27e66d77f276c23a7ca2eaa8869438fb4d31
Author: prashkre <email address hidden>
Date: Thu Jan 25 13:41:42 2018 +0530

    Mask passwords only when command execution fails

    At many places, processutils.ssh_execute() is being invoked to run
    a command over ssh and output returned is parsed to get appropriate
    information. In this flow, unsanitized output is being expected
    where processutils.ssh_execute() was invoked but found that
    output like volume details(containing "password" string in its name)
    is being masked away with strutils.mask_password(stdout) even though
    no error occured during command execution.

    This is regression issue from patch[0]. In this fix, stdout and stderr
    in processutils.ssh_execute() will be masked only when
    ProcessExecutionError exception is thrown i.e. command execution failed
    due to some reasons.

    [0] https://github.com/openstack/oslo.concurrency/commit/
    ae9e05bfc3d7ec867bd6ec78c301f11c2bdd0d5f

    Change-Id: I2ce344330905eef437ef3f89a2a01169a30df8ab
    Closes-Bug: #1482382