oslo.serialization

  1. Bug #1604213
  2. Comment #0

Comment 0 for bug 1604213

Revision history for this message
Haifeng.Yan (yanheven) wrote :

oslo.config$ grep 'self.assertEqual(self' -r oslo_config/tests/

oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'baaar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.newfoo, 'last')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 'bar')
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 666)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, 6.66)
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, ['bar'])
oslo_config/tests/test_cfg.py: self.assertEqual(self.conf.foo, ['bar'])
...

These misplace have 2 issue:
1, confusing message when some tests failed.
2, mislead other developer, new test module may follow these wrong pattern.