Comment 14 for bug 1983863

Revision history for this message
sean mooney (sean-k-mooney) wrote :

nova does not depend on the multi reader behavior and never has.
the modification to oslo.log was done mainly because of issues reported in cinder and while the
same error could happen in nova if you tried to logs form within an eventlet.tpool we were not doing that.

so yes I'm saying this is an implementation detail of how oslo.logs works form a nova perspective and modifying the internals of oslo log to not call eventlet.debug.hub_prevent_multiple_readers(False)

does not require code changes in nova.

nothing in nova depends on "eventlet.debug.hub_prevent_multiple_readers(False)"

nova is only listed on this bug report because the oslo change broke our unit tests
https://review.opendev.org/c/openstack/nova/+/894538
and it did so during a code freeze period coming up to a release so it was blocking our gate.

the code change i made to nova was a purely test only change adding additional mocking to avoid running
the PipeMutex oslo.log code in our unit tets.