Whoops, you're right. It would work anyway because of the count check in the next line, but it wasn't what I intended. /me is bad at regexes
I did run across some builtin regexes related to string formatting, but they were all for the {} style of formatting instead of %(). Every interpolation-related one I could find had issues (including the one we were previously using in oslo.i18n), which is why I tried to keep this one as simple as possible.
I did forget one other case too though, which is when a dict is passed and only a %s is included. In that case the entire dict will get logged. I will update the patch for that and the s/*/+/ change.
Whoops, you're right. It would work anyway because of the count check in the next line, but it wasn't what I intended. /me is bad at regexes
I did run across some builtin regexes related to string formatting, but they were all for the {} style of formatting instead of %(). Every interpolation- related one I could find had issues (including the one we were previously using in oslo.i18n), which is why I tried to keep this one as simple as possible.
I did forget one other case too though, which is when a dict is passed and only a %s is included. In that case the entire dict will get logged. I will update the patch for that and the s/*/+/ change.