Comment 10 for bug 1628938

Reviewed: https://review.openstack.org/441250
Committed: https://git.openstack.org/cgit/openstack/os-win/commit/?id=e09f672e228379dbeeebad4156891ddb75a06769
Submitter: Jenkins
Branch: master

commit e09f672e228379dbeeebad4156891ddb75a06769
Author: Lucian Petrut <email address hidden>
Date: Fri Mar 3 19:15:06 2017 +0200

    Fix cluster group migration status checks

    We incorrectly assumed that the group state will immediately become
    'Pending' when a migration is requested, judging by the expected
    'ErrorPending' return code of the move function.

    This is not the case, as the group can be reported as 'Online' while
    being on the source node, before a live migration is actually
    performed successfully. This is incorrectly treated as an exception
    at the moment.

    This change refactors the way in which we check pending migrations.
    We rely on cluster group state change events in this matter.

    In case of migration timeouts, we're now attempting to cancel pending
    migrations.

    Also, some of the private methods functionality is now publicly
    exposed (e.g. canceling migrations, detecting queued migrations).

    In the future, we're planning to implement a custom cluster resource
    dll, having a finer control over this.

    Closes-Bug: #1628938

    Change-Id: I6c268355213718d4d66e0e77a89c558cde3213b6