Comment 4 for bug 1967790
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to os-brick (stable/yoga) | #4 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
Reviewed: https:/
Committed: https:/
Submitter: "Zuul (22348)"
Branch: stable/yoga
commit 0bd5dc99152261d
Author: Gorka Eguileor <email address hidden>
Date: Mon Apr 4 20:01:39 2022 +0200
Fix encryption symlink issues
This patch fixes 2 issues related to the symlinks, or lack of, that
connectors' connect_volume methods return.
Some connectors always return the block device instead of a symlink for
encrypted volumes, and other connectors return a symlink that is owned
by the system's udev rules. Both cases are problematic
Returning the real device can prevent the encryptor connect_volume to
complete successfully, and in other cases (such as nvmeof) it completes,
but on the connector's disconnect volume it will leave the device behind
(i.e., /dev/nvme0n1) preventing new connections that would use that same
device name.
Returning a symlink owned by the system's udev rules means that they can
be reclaimed by those rules at any time. This can happen with
cryptsetup, because when it creates a new mapping it triggers udev rules
for the device that can reclaim the symlink after os-brick has replaced
it.
This patch creates a couple of decorators to facilitate this for all
connectors. These decorators transform the paths so that the callers
gets the expected symlink, but the connector doesn't need to worry about
it and will always see the value it returns regardless of what symlink
the caller gets.
From this moment onwards we use our own custom symlink that starts with
"/dev/
The patch fixes bugs in other connectors (such as the RBD local
connection), but since there are no open bugs they have not been
reported.
Closes-Bug: #1964379
Closes-Bug: #1967790
Change-Id: Ie373ab050dcc0a
(cherry picked from commit 1583a5038d34fd5