os-brick

  1. Bug #1780813
  2. Comment #15

Comment 15 for bug 1780813

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to os-brick (stable/pike)

Reviewed: https://review.openstack.org/647766
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=f64ad529bfd836a6e18199c3b7d22ff4e07be2c5
Submitter: Zuul
Branch: stable/pike

commit f64ad529bfd836a6e18199c3b7d22ff4e07be2c5
Author: Eric Harney <email address hidden>
Date: Wed Oct 10 16:46:01 2018 -0400

    Fix NFS "already mounted" detection

    Previous fix

    2f32c98a RemoteFS: don't fail in do_mount if already mounted

    was made with the assumption that "already mounted" appearing
    in stderr from an NFS mount means that the NFS share was already
    mounted.

    However, the NFS client can fail with "busy or already mounted"
    in cases where it fails to mount the share as well.

    This results in the Cinder NFS backup driver believing that the
    NFS mount has succeeded when it didn't, and as a result, data
    can be written to the local disk instead of the NFS target.

    Fail if the share isn't actually mounted rather than succeeding.

    Related-Bug: #1780813
    Closes-Bug: #1797233
    Change-Id: Iebd1afb3340fcaeb1969784966c4f9be35a28417
    (cherry picked from commit 360a20c7c7b4c385255200a574edc0ca1ac8d87c)
    (cherry picked from commit 4c94477cb525b25f178d52ff1b01bfe1fc3d3dd3)
    (cherry picked from commit 30d7bc124e564d4a2c288f3666d8d14dc96fb9f5)