Comment 4 for bug 396985

Revision history for this message
Sebastian Max (smx-comnets) wrote : Re: [openWNS-bugsquad] [Bug 396985] Re: preparecampaign psycopg2.IntegrityError: null value in column "id" violates not-null constraint

Hi all,

> to 1) I filed a new bug and will fix it asap.
> https://bugs.launchpad.net/bugs/397076
Fixed, commited, Done.

> to 3) I moved most of the database related stuff from PyWNS to wrowser
> some time ago. It seems that this was not done consistently. There
> should be only
> one place where to find these files.
Imports are changed, bugfix is commited.

> to 4) I totally agree, but I would propose a different solution.
> The script should take arguments and do proper error reporting and
> console logging. Instead of implicitly assuming the current user, using
> a default
> password, default database name and host, it should use command line
> options and or interactive queries to the user. It could also be very
> well integrated with the createcampaign plugin.
I have submitted an intermediate fix that aborts the operation if the
user is "root" or "postgres" - normal user rights are sufficient for the
script, and . I also agree with Daniel, but this takes more time to do...

BR,
Sebastian