corruption of files

Bug #900848 reported by Miguel Angel
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenTeacher
2.x
Fix Released
High
Marten de Vries

Bug Description

hello;

first of all thanks for this awesome applications which I use it a lot.

The bug, is not exactly a bug, I have realized that while entering words sometimes you leave one with the right format but with no translation, just because you may want to check it out again if it was corrected or for whatever reason. if you forget about that line which is like foreing = and press the enter button the program will render the file unreadable.

It will tell you that the file is not an OT file or that it is corrupted. I found the solution after several cracks while editing it with a text editor and writing something for the translation answer.

I do not know how to do it since I am not a computer scientist but I guess that implementing some rule that will not validate the line unless has a minimum of foreign = translation1 and leave it in the context box for its completion will correct it.

thanks

Changed in openteacher:
importance: Undecided → Medium
milestone: none → 2.3
status: New → Incomplete
Revision history for this message
Marten de Vries (marten-de-vries) wrote :

Hi Miguel,

However I could reproduce a situation that looks similar to the one you describe, I can't be sure it's the same without some extra information. Can you provide another description of the following? (I'm not native English): 'I have realized that while entering words sometimes you leave one with the right format but with no translation, just because you may want to check it out again if it was corrected or for whatever reason.' Also an example file that doesn't open can come in handy, it's possible to add it as an attachment by clicking the 'Add attachment or patch' link below the comment field.

Thank you for taking time to make OpenTeacher better by reporting this bug!

Revision history for this message
Miguel Angel (masalcedo1) wrote : Re: [Bug 900848] Re: corruption of files
Download full text (3.2 KiB)

Hi Marten;

I am not native english either :-D but yes, you got it right. Explaining
it further, now I am making a 1500 word file and while entering more
lines I type this in the box;

> breaking point = perder los nervios
>
> subsequent = subsiguiente
>
> overruled = dominar, predominar
>
> ancillary = auxiliar, subordinado
>
> avowedly = confesadamente, declaradamente
>
> avowe =
>
> term of office = tenencia
>
> discharge = descarga
>
> discharge of the national budget = descarga del presupuesto nacional
>
If for some reason I do not realize that I just left that line without
completion, without any translation at all, and I press enter, the
program will enter all the lines but it will also render the file
corrupted. Next time I will try to open it, it will say: the file is not
an openteacher format or it is a corrupted file (sort of).

But if that same file, you open it with a text editor, look for the
avowe line and enter any letter in the translation part of the code it
will become once again readable. Like doing this;

> <word><known>avowe</known><foreign>A</foreign>

It is not a bug, it is just that if you do not do it correctly for some
reason, in my case because I enter in the box like 30 words everytime
and checked them up before pressing enter, if I miss that I have not
completed one the program will accept it and then it comes the trouble.

Thanks again for the program, I am not a coder so I could not do this
and have no clue how to improve it, if so I would have done it myself. I
have make my file corrupted and attached it already. I have opened with
a text editor and wiped out the first word's translation "zillion".

For anything I could do please tell me.

Thanks

Miguel Angel

P.S; I think It would be very interesting if the community would have a
place to share files for learning, kind of something like artista
transcoder does letting you updload presets for your devices so anyone
will have them available. I am up to uploading all the files that I make
for myself.

--
------------------------------------------------------------------------
pic
 Miguel Ángel Salcedo

+34 653-699-936 <callto:0034653699936>
+34 983-407-051 <callto:0034983407051>
<email address hidden> <mailto:<email address hidden>>
<email address hidden> <mailto:<email address hidden>>
pin:20DC8C7D

*Please consider the environment before printing this email.*
------------------------------------------------------------------------

On 06/12/11 20:44, Marten de Vries wrote:
> Hi Miguel,
>
> However I could reproduce a situation that looks similar to the one you
> describe, I can't be sure it's the same without some extra information.
> Can you provide another description of the following? (I'm not native
> English): 'I have realized that while entering words sometimes you leave
> one with the right format but with no translation, just because you may
> want to check it out again if it was corrected or for whatever reason.'
> Also an example file that doesn't open can come in handy, it's possible
> to add it as an attachment by clicking the 'Add attachment or patch'
> link below the comment field.
>
> Thank you for taking time to make OpenTeacher better b...

Read more...

Revision history for this message
Milan Boers (milan-boers) wrote :

Hi Miguel,

In OpenTeacher 2, we have chosen for a design where it's impossible to have empty answers. Therefore what you want can not be done in OpenTeacher 2. I recommend you to use a placeholder text instead of a whitespace.

The fact that it is possible to enter words with a whitespace/nothing as answer is a bug. This should not be possible in OpenTeacher 2. We will make this impossible in 2.3.

The design of OpenTeacher 3 will be/is different. In OpenTeacher 3 it will be possible to enter whitespaces/nothing as answer.

Changed in openteacher:
status: Incomplete → Triaged
Revision history for this message
Miguel Angel (masalcedo1) wrote :

Hi Milan

Thanks for answering. The thing is not that I do want to enter words with no translation, I just realized this issue because I got corrupted two files and the third one I figured it out since I saw it.

I only wanted to rise the awareness because when I started to use I remember saying to myself... ok maybe it is not so good idea to be so many hours entering your translations since the program may render the file corrupted and all the work goes to the waste bin.

I'm fine the program, I think its cool, I do not mind at all that this happens.

looking forward to the 3.0 version, I am using 2.2.1

Thanks

Revision history for this message
Marten de Vries (marten-de-vries) wrote :

'I do not mind at all that this happens.'

I do :P. So we'll make sure the program gives an error when pressing the enter button, not after trying to reload a saved file. It'll be in the next release. As Milan noted already, in the 3.0 (that was completely rewritten) this will be fixed anyway.

Revision history for this message
Marten de Vries (marten-de-vries) wrote :

And I just did what I described in comment #5. It'll be in the next (2.3) release.

Changed in openteacher:
status: Triaged → Fix Committed
assignee: nobody → Marten de Vries (marten-de-vries)
no longer affects: openteacher
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.