VMware: fix snapshot failure when host in maintenance mode
The root cause is due to a bug in the VC's handling of the
VirtualDiskManager.DeleteVirtualDisk_Task API, which allows the picking
of any host in a datacenter with access to the datastore participating
in the disk deletion picked be to perform the operation, even when the
host is in maintenance mode and hence will always reject the call when
sent.
The fix uses an alternative API (FileManager.DeleteDatastoreFile_Task)
to delete the vmdk and -flat vmdk files separately. This API does not
suffer from the above-mentioned failure mode.
Closes-Bug: #1229994
(cherry picked from commit 7910385825ccfa705785af360fcd5717656e3557)
Reviewed: https:/ /review. openstack. org/58703 github. com/openstack/ nova/commit/ 96257fd7d5ecd00 e0eb84b110e52eb 811d268d55
Committed: http://
Submitter: Jenkins
Branch: stable/havana
commit 96257fd7d5ecd00 e0eb84b110e52eb 811d268d55
Author: Vui Lam <email address hidden>
Date: Mon Sep 30 11:25:41 2013 -0700
VMware: fix snapshot failure when host in maintenance mode
The root cause is due to a bug in the VC's handling of the Manager. DeleteVirtualDi sk_Task API, which allows the picking
VirtualDisk
of any host in a datacenter with access to the datastore participating
in the disk deletion picked be to perform the operation, even when the
host is in maintenance mode and hence will always reject the call when
sent.
The fix uses an alternative API (FileManager. DeleteDatastore File_Task)
to delete the vmdk and -flat vmdk files separately. This API does not
suffer from the above-mentioned failure mode.
Closes-Bug: #1229994
(cherry picked from commit 7910385825ccfa7 05785af360fcd57 17656e3557)
Conflicts: virt/vmwareapi/ fake.py virt/vmwareapi/ vmops.py
nova/
nova/
Change-Id: I786365847673e5 192a21b654cba95 1b2e7a6f291