[API] Composed node /nodes didn't have show correct content

Bug #1636826 reported by chesterkuo
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Valence
Fix Released
Critical
Lin Yang

Bug Description

with common/redfish/api.py, def nodes_list(),

bmc_ip is hard-code and should be displayed in the metadata property of nodes, same issue as bmcmac, nw.

more data need add into node detail.

Revision history for this message
chesterkuo (chester-kuo) wrote :

also , we should not use node id as below in code, the redfish id and will confuse with id of location,
suggest to use url_id as we had in API, make sense ?

nodeid = lnk.split("/")[-1]

Revision history for this message
chesterkuo (chester-kuo) wrote :

the nodeid may have duplicate entry if support to multiple POD environment, ex:

/redfish/v1/nodes/node1 show in PODM1 , and another PODM may have also same node url id.

Lin Yang (lin-a-yang)
Changed in openstack-valence:
assignee: nobody → Lin Yang (lin-a-yang)
importance: Undecided → Critical
milestone: none → ocata-1
Revision history for this message
Ananth Narayan S (ananth-narayan) wrote :

Not related to : 1636826 though the title is very similar.

Revision history for this message
Lin Yang (lin-a-yang) wrote :

I have marked https://bugs.launchpad.net/openstack-valence/+bug/1636826 is duplicated to this one.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to valence (master)

Fix proposed to branch: master
Review: https://review.openstack.org/418657

Changed in openstack-valence:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to valence (master)

Reviewed: https://review.openstack.org/418657
Committed: https://git.openstack.org/cgit/openstack/valence/commit/?id=59d6a712a0d1768a8625b62cc319922f0b27fbf2
Submitter: Jenkins
Branch: master

commit 59d6a712a0d1768a8625b62cc319922f0b27fbf2
Author: Lin Yang <email address hidden>
Date: Tue Jan 10 19:17:08 2017 -0800

    Align api /nodes with api-ref spec

    1. Return briefly info of node after composed node
    2. Fixed hardcode fields in node details, like ip addr, mac, etc.
       Added more fields according to valence api spec.

    Change-Id: I9291b1245895fd7693f5e960559e9f29a314b712
    Closes-Bug: #1636826

Changed in openstack-valence:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.