Comment 2 for bug 1753539

Revision history for this message
Victor Morales (electrocucaracha) wrote :

The undeclared variables were defined for libvirt versions > 2.0.0 [1], but the checker function includes 1.1.0 [2][3]. Modifying the arguments of LIBVIR_CHECK_VERSION to 2.0.0 works

diff --git a/libvirt-override.c b/libvirt-override.c
index 580c259..a7077f2 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -7738,7 +7738,7 @@ libvirt_virDomainMigrateGetMaxDowntime(PyObject *self ATTRIBUTE_UNUSED,
 }
 #endif /* LIBVIR_CHECK_VERSION(3, 7, 0) */

-#if LIBVIR_CHECK_VERSION(1, 1, 0)
+#if LIBVIR_CHECK_VERSION(2, 0, 0)
 static virPyTypedParamsHint virPyDomainMigrate3Params[] = {
     { VIR_MIGRATE_PARAM_URI, VIR_TYPED_PARAM_STRING },
     { VIR_MIGRATE_PARAM_DEST_NAME, VIR_TYPED_PARAM_STRING },
@@ -9845,7 +9845,7 @@ static PyMethodDef libvirtMethods[] = {
     {(char *) "virDomainMigrateGetMaxDowntime", libvirt_virDomainMigrateGetMaxDowntime, METH_VARARGS, NULL},
 #endif /* LIBVIR_CHECK_VERSION(3, 7, 0) */
     {(char *) "virDomainMigrateGetMaxSpeed", libvirt_virDomainMigrateGetMaxSpeed, METH_VARARGS, NULL},
-#if LIBVIR_CHECK_VERSION(1, 1, 0)
+#if LIBVIR_CHECK_VERSION(2, 0, 0)
     {(char *) "virDomainMigrate3", libvirt_virDomainMigrate3, METH_VARARGS, NULL},
     {(char *) "virDomainMigrateToURI3", libvirt_virDomainMigrateToURI3, METH_VARARGS, NULL},
 #endif /* LIBVIR_CHECK_VERSION(1, 1, 0) */

I'm going to send the patch to libvirt community

[1] https://github.com/libvirt/libvirt/commit/f6e12b40295b1601b9911f6ccb46e09bf8e47e85
[2] https://github.com/libvirt/libvirt-python/blob/master/libvirt-override.c#L7741
[3] https://github.com/libvirt/libvirt-python/blob/master/libvirt-override.c#L9848