"barbican help" needs authentication

Bug #1488934 reported by Atsushi SAKAI
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstack-manuals
Fix Released
Medium
KATO Tomoyuki
python-barbicanclient
Fix Released
Undecided
Elvin Tubillara

Bug Description

"barbican help" needs authentication.
Of course, we know "barbican --help" works.
But it also need to work "barbican help xxxx" without authentication.

This is required for executing autogenerate cli-reference.

  https://github.com/openstack/openstack-doc-tools/blob/master/bin/doc-tools-update-cli-reference

$ barbican help complete
ERROR: please specify authentication credentials

Atsushi SAKAI (sakaia)
tags: added: cli-reference
Changed in openstack-manuals:
status: New → Confirmed
importance: Undecided → Medium
Changed in python-barbicanclient:
assignee: nobody → Elvin Tubillara (edtubill)
status: New → Confirmed
Revision history for this message
Atsushi SAKAI (sakaia) wrote :

Thank you for doing this bug.
At this reporting, following two command type is required.
  barbican help
  barbican help xxxx

After above fixation on nova, and found one more subcommand needs fixation.
  barbican bash-completion

hopefully consider this report

(nova help)
https://bugs.launchpad.net/python-novaclient/+bug/1491677
(nova bash-completion)
https://bugs.launchpad.net/python-novaclient/+bug/1495424

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-barbicanclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/224467

Changed in python-barbicanclient:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-barbicanclient (master)

Reviewed: https://review.openstack.org/224467
Committed: https://git.openstack.org/cgit/openstack/python-barbicanclient/commit/?id=89c2f286a6246606335f31abf1a6289e89b427f2
Submitter: Jenkins
Branch: master

commit 89c2f286a6246606335f31abf1a6289e89b427f2
Author: Elvin Tubillara <email address hidden>
Date: Thu Sep 17 02:30:20 2015 -0500

    enable barbican help without authentication

    This fix enables 'barbican help' and 'barbican complete' to
    not need authentication. This commit also enables deferred_help
    so that the following command can be ran:
    'barbican secret list --help' (the help for the
    particular command will be shown).
    The code changes are similar to the python-openstackclient
    usage of the cliff library. The current implementation
    of the barbican client authenticates before checking the type of
    command. This early authentication causes the client
    to fail with 'barbican help'. This code change will
    check if the command requires authentication
    and creates the client.

    Change-Id: If335ef0373c75b145dc696d8501153da59fff1b7
    Closes-Bug: #1488934

Changed in python-barbicanclient:
status: In Progress → Fix Committed
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/python-barbicanclient 4.0.0

This issue was fixed in the openstack/python-barbicanclient 4.0.0 release.

Changed in openstack-manuals:
assignee: nobody → KATO Tomoyuki (kato-tomoyuki)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-manuals (master)

Reviewed: https://review.openstack.org/288193
Committed: https://git.openstack.org/cgit/openstack/openstack-manuals/commit/?id=ad0dddd95bcfcddb4f9b8c330041d3be8e61d92f
Submitter: Jenkins
Branch: master

commit ad0dddd95bcfcddb4f9b8c330041d3be8e61d92f
Author: venkatamahesh <email address hidden>
Date: Fri Mar 4 05:51:13 2016 +0530

    [cli-ref] Update python-barbicanclient to 4.0.0

    Closes-Bug: #1488934

    Change-Id: I32d914b145bd69ab2589664f49ddbd148d53bf64

Changed in openstack-manuals:
status: In Progress → Fix Released
Changed in openstack-manuals:
milestone: none → mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-manuals 15.0.0

This issue was fixed in the openstack/openstack-manuals 15.0.0 release.

Jeremy Liu (liujiong)
Changed in python-barbicanclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.