"nova --help" needs authentication causes cli-reference generation trouble

[Atsushi SAKAI]

nova --help needs authentication

$ nova --help
ERROR (CommandError): You must provide a username or user id via --os-username, --os-user-id, env[OS_USERNAME] or env[OS_USER_ID]

Would you treat same authentication level?
following command does not need authentication
nova help
nova help xxxx

Current authentication level for --help causes cli-reference generation trouble.

[Atsushi SAKAI (sakaia)]

Affected python-novaclient version is
2.27.0

[Ramaraja (ramaraja-r)]

There is a change in novaclient 2.27.0 do_help logic. unfortunately this logic will work for only 'help' argument. I think we may need to add '--help' and '-h' in addition.

I suspect this line:

https://github.com/openstack/python-novaclient/blob/2.27.0/novaclient/shell.py#L559

[Atsushi SAKAI (sakaia)]

[FYI] still have a problem on python-novaclient 2.28.1

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/220919

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/221488

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/220919
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=ca031f991565a3764f8c36bdd28c942ab383b4d3
Submitter: Jenkins
Branch: master

commit ca031f991565a3764f8c36bdd28c942ab383b4d3
Author: Ramaraja <email address hidden>
Date: Mon Sep 7 14:33:16 2015 +0530

    Fix nova --help needs authentication

    Added --help,-h in do_help flag so that authentication will not be prompted.

    Change-Id: Iafb766304eeda58eff0c92b87a127018820832fd
    Closes-Bug: #1491677

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/221488
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=d0b44893ac4fc3cda215cba20b8b9330e9fa92c3
Submitter: Jenkins
Branch: master

commit d0b44893ac4fc3cda215cba20b8b9330e9fa92c3
Author: melanie witt <email address hidden>
Date: Tue Sep 8 20:08:37 2015 +0000

    Add unit tests for different help commands

    Related-Bug: #1491677

    Change-Id: I7e6b74e60dafa0e869a5b3355793cda1cf08c389

[Atsushi SAKAI (sakaia)]

Currently Nova documentation is up to date.