commit 8b982ed886d5caf085d9028b2c627362f7df90c9
Author: Clark Boylan <email address hidden>
Date: Tue Aug 26 15:25:42 2014 -0700
Handle utf8 in JJB
JJB didn't actually handle unicode data very well for a couple reasons.
First the local yaml loader was loading files into yaml as strings
instead of unicode which we should just go ahead and do because yaml's
built int loader loads utf-8 by default (and we don't override the
default). Second we need to do parameter substitution on unicode and
regular strings so change the substitution typecheck to use basestring
instead of str. Finally we need to use UTF-8 as the encoding when
emitting XML so do that.
Add tests to actually test this in the yamlparser tests. The addition of
these new tests comes with a little bit of cleanup in the test classes
to make sure we load unicode files as utf8 more consistently.
Reviewed: https:/ /review. openstack. org/117041 /git.openstack. org/cgit/ openstack- infra/jenkins- job-builder/ commit/ ?id=8b982ed886d 5caf085d9028b2c 627362f7df90c9
Committed: https:/
Submitter: Jenkins
Branch: master
commit 8b982ed886d5caf 085d9028b2c6273 62f7df90c9
Author: Clark Boylan <email address hidden>
Date: Tue Aug 26 15:25:42 2014 -0700
Handle utf8 in JJB
JJB didn't actually handle unicode data very well for a couple reasons.
First the local yaml loader was loading files into yaml as strings
instead of unicode which we should just go ahead and do because yaml's
built int loader loads utf-8 by default (and we don't override the
default). Second we need to do parameter substitution on unicode and
regular strings so change the substitution typecheck to use basestring
instead of str. Finally we need to use UTF-8 as the encoding when
emitting XML so do that.
Add tests to actually test this in the yamlparser tests. The addition of
these new tests comes with a little bit of cleanup in the test classes
to make sure we load unicode files as utf8 more consistently.
Change-Id: I2169e19aae2cdc 7ddbd1e7217ef75 84c786a039a
Fixes-bug: 1361090