Reviewed: https://review.openstack.org/207303 Committed: https://git.openstack.org/cgit/openstack/api-site/commit/?id=63ff61c8d69719acf80ff3217446d57b1b99ed6a Submitter: Jenkins Branch: master
commit 63ff61c8d69719acf80ff3217446d57b1b99ed6a Author: Keiichiro Tokunaga <email address hidden> Date: Thu Jul 30 14:41:59 2015 +0900
Add missing err res codes to "Create floating IP"
"Error response codes" of "Create floating IP" is missing Not Found (404) like this:
Error response codes badRequest (400), unauthorized (401), conflict (409)
Please see http://developer.openstack.org/api-ref-networking-v2-ext.html#createFloatingIp .
Actually, it has a description about error codes and there is Not Found (404) there like this:
Error codes:
- 400 The operation returns this error code for one of these reasons:
o The specified network is not external, such as router:external=False.
o The specified internal OpenStack Networking port is not associated with the floating IP address.
o The requested floating IP address does not fall in the subnet range for the external network.
o The specified fixed IP address is not valid.
- 404 The specified port ID is not valid.
- 409 The operation returns this error code for one of these reasons:
o The requested floating IP address is already in use.
o The internal OpenStack Networking port and specified fixed IP address are already associated with another floating IP.
However, now it's missing unauthorized (401) there.
So, in summary, we need the following two fixes. This patch fixes both of them.
1) Add Not Found (404) to "Error response codes" 2) Add unauthorized (401) to "Error codes" description
Change-Id: Ie3fc32b85b7812736094d46390642facff65f257 Closes-Bug: #1479629
Reviewed: https:/ /review. openstack. org/207303 /git.openstack. org/cgit/ openstack/ api-site/ commit/ ?id=63ff61c8d69 719acf80ff32174 46d57b1b99ed6a
Committed: https:/
Submitter: Jenkins
Branch: master
commit 63ff61c8d69719a cf80ff3217446d5 7b1b99ed6a
Author: Keiichiro Tokunaga <email address hidden>
Date: Thu Jul 30 14:41:59 2015 +0900
Add missing err res codes to "Create floating IP"
"Error response codes" of "Create floating IP" is missing
Not Found (404) like this:
Error response codes
badRequest (400), unauthorized (401), conflict (409)
Please see http:// developer. openstack. org/api- ref-networking- v2-ext. html#createFloa tingIp .
Actually, it has a description about error codes and there
is Not Found (404) there like this:
Error codes:
- 400 The operation returns this error code for one of
these reasons:
o The specified network is not external, such as
router: external= False.
o The specified internal OpenStack Networking port
is not associated with the floating IP address.
o The requested floating IP address does not fall
in the subnet range for the external network.
o The specified fixed IP address is not valid.
- 404 The specified port ID is not valid.
- 409 The operation returns this error code for one of
these reasons:
o The requested floating IP address is already in use.
o The internal OpenStack Networking port and specified
floating IP.
fixed IP address are already associated with another
However, now it's missing unauthorized (401) there.
So, in summary, we need the following two fixes. This patch fixes
both of them.
1) Add Not Found (404) to "Error response codes"
2) Add unauthorized (401) to "Error codes" description
Change-Id: Ie3fc32b85b7812 736094d46390642 facff65f257
Closes-Bug: #1479629