Adding host attaching support to Cinder

[OpenStack Infra]

https://review.openstack.org/#/c/34125/
commit e8fc695fdd831e058a745607e873e14bef188f22
Author: Zhi Yan Liu <email address hidden>
Date: Mon Jun 17 05:17:45 2013 +0800

    Adding host attaching support to Cinder

    Changing 'os-attach' API interface to allow client mark a volume as be
    attached to a host.

    Implement bp: volume-host-attaching
    docimpact

    Change-Id: Iaf442ad0fb37ce369d838f3a512724f830071763
    Signed-off-by: Zhi Yan Liu <email address hidden>

[Diane Fleming (diane-fleming)]

I need more information: Is os-attach a cinder extension or a nova extension?

What's the syntax? Are there code samples?

thanks.

[Diane Fleming (diane-fleming)]

backport: havana

[Tom Fifield (fifieldt)]

Diane, this is an automatically created bug - so to get the answer, you'll need to email the address listed in the bug report.

[Diane Fleming (diane-fleming)]

Note to <email address hidden> <email address hidden> 12/2/13:

Zhi,

I'm working on bug 1193770 (https://bugs.launchpad.net/openstack-api-site/+bug/1193770), but I need more information:

Is os-attach a cinder extension or a nova extension?

What's the syntax? Are there code samples?

thanks.

[Zhi Yan Liu (lzy-dev)]

Diane,

1. os-attach is a cinder extension.
2. the only syntax is "host_name", and client can pass a host name string via it.

thanks.

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/89284

[Diane Fleming (diane-fleming)]

Note to <email address hidden> <email address hidden> 4/22/2014

Zhi,

I need a little more information about this bug -

You wrote:

os-attach is a cinder extension.
the only syntax is "host_name", and client can pass a host name string via it.
However, on which call can a client pass a host_name?

create volume (cinder create)?

attach volume (nova volume-attach)?

something else?

Thanks!

[Diane Fleming (diane-fleming)]

I still cannot figure out how this works. Not anywhere in the cinder client - I need more information.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Diane Fleming (<email address hidden>) on branch: master
Review: https://review.openstack.org/89284
Reason: abandoning - cannot figure out how this works

[Atsushi SAKAI (sakaia)]

Let me clearify

os-attach uses
volume_api.attach
https://github.com/openstack/cinder/blob/stable/kilo/cinder/api/contrib/volume_actions.py#L118

volume_api uses self.volume_api = volume.API()
https://github.com/openstack/cinder/blob/stable/kilo/cinder/api/contrib/volume_actions.py#L76

volume uses "from cinder import volume"
https://github.com/openstack/cinder/blob/stable/kilo/cinder/api/contrib/volume_actions.py#L28

I am looking around the code and found API().
https://github.com/openstack/cinder/blob/stable/kilo/cinder/volume/__init__.py

And its default parameter is API()=cinder.volume.api.API
http://docs.openstack.org/kilo/config-reference/content/section_cinder.conf.html

So In API, attach_volume is called. So I am wondering attach_volume meaning in #7
since cinder volume attach is not commented in #7

[Atsushi SAKAI (sakaia)]

attach_volume itself documented here
http://docs.openstack.org/developer/cinder/api/cinder.volume.rpcapi.html

[Atsushi SAKAI (sakaia)]

From #7 related, function call path is written in following.

Section 7.2.x describe detail
https://github.com/minggLu/MOC/wiki/nova-volume-attach-api-call-code-flow

So this path coming from "nova volume-attach".

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/219200

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/219200
Committed: https://git.openstack.org/cgit/openstack/api-site/commit/?id=4815dcbd2fef2ada84dc69bd45a7749f8be56317
Submitter: Jenkins
Branch: master

commit 4815dcbd2fef2ada84dc69bd45a7749f8be56317
Author: Atsushi SAKAI <email address hidden>
Date: Tue Sep 1 18:19:26 2015 +0900

    Add host attaching support to cinder

    This function is a kind of setting status to cinder

    Fix one typo
      os-os-unset_image_metadata => os-unset_image_metadata

    Fixed a couple of other os-os typos (df)

    Change-Id: I7e33f6227655f0e881b81a8708d65a0591b344b3
    Closes-Bug: #1193770