Comment 17 for bug 2034583

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible-os_nova/+/898779
Committed: https://opendev.org/openstack/openstack-ansible-os_nova/commit/77c06d452048b837984118d801f1e62122f3b7e6
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 77c06d452048b837984118d801f1e62122f3b7e6
Author: Dmitriy Rabotyagov <email address hidden>
Date: Wed Oct 18 19:04:46 2023 +0200

    Fix logic of discovering hosts by service

    For quite some time, we relate usage of --by-service flag for
    nova-manage cell_v2 discover_hosts command to the used nova_virt_type.
    However, we run db_post_setup tasks only once and delegating to the
    conductor host. With latest changes to the logic, when this task in
    included from the playbook level it makes even less sense, since
    definition of nova_virt_type for conductor is weird and wrong.

    Instead, we attempt to detect if ironic is in use by checking hostvars
    of all compute nodes for that. It will include host_vars, group_vars,
    all sort of extra variables, etc.

    Thus, ironic hosts should be better discovered now with nova-manage
    command.

    Related-Bug: #2034583
    Change-Id: I3deea859a4017ff96919290ba50cb375c0f960ea
    (cherry picked from commit 4aa65eb60691c50c9022c22848e3338c8f350af3)