Comment 3 for bug 1471190

Reviewed: https://review.openstack.org/198311
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=d339da31035f03e226e335be794c3ac114148430
Submitter: Jenkins
Branch: master

commit d339da31035f03e226e335be794c3ac114148430
Author: Matt Thompson <email address hidden>
Date: Fri Jul 3 12:02:47 2015 +0100

    Fix scripts/run-upgrade.sh

    Currently, scripts/run-upgrade.sh will not successfully upgrade a
    deploy from juno->kilo. This update does the following:

    - copies etc/openstack_deploy/env.d/* to /etc/openstack_deploy/env.d
    - uses ansible modules where possible rather than using the ansible
      shell module
    - forces ansible command to return true where necessary (we introduce
      new ansible host groups in kilo and these groups do not yet have
      containers built which will cause the ansible command to fail)
    - updates the python code to keep is_metal configurations between
      juno and kilo deployments (kilo defaults is_metal=true for
      cinder_volumes, which was not the default on juno)
    - moves a closing if statement higher up in the script which was
      erroneously causing a bunch of code to be skipped

    Change-Id: Ic99dcbc3f64b8dbfec6188a017a8bcda1c80e544
    Closes-Bug: #1471190
    Co-Authored-By: Kevin Carter <email address hidden>