Comment 5 for bug 1257264

Thanks, Mike. I like that approach better -- it seems more future-proof / less reliant on internals, and JSON::XS seems to have had is_bool since the 1.x days in 2007.

I've signed off on Galen's latest branch and incorporated an additional commit with the tests I had added in my not-yet-pushed branch today.

Running it through the paces now:

Debian Wheezy system alternating between the following two versions of JSON::XS:

* the packaged 2.320-1+b1 version of libjson-xs-perl
* after installing JSON::XS 3.01 via "cpan JSON:XS" (which also installs Types::Serialiser)

"make check" for OpenSRF succeeds for branch user/jeff/lp1257264_fix_plus_test_cases_signoff
"make check" for OpenSRF succeeds for rel_2_2 with cherry-picked commits user/jeff/lp1257264_fix_plus_test_cases_backport

Testing service startup

Testing with Evergreen 2.5.1 and the two above JSON::XS versions.

service startup, previously problematic srfsh query, and staff client login, retrieval of admin user by db id, visit user editor and user permission editor: success!

signed off branch: user/jeff/lp1257264_fix_plus_test_cases_signoff
backported (clean cherry pick) to rel_2_2: user/jeff/lp1257264_fix_plus_test_cases_backport

My latest commit lacks a signoff at this point, but other than that, I think we're looking good.