Took a quick look at this. I agree with removing the indefinite wait, but backlog processing will need to be tested, as with the proposed patch $from_network never changes value. Something like this might capture the intent better:
if ($msg) {
# we just popped a message from the backlog queue
# let's see if we can process it
$from_network = 0;
} else {
$msg = $self->{osrf_handle}->process($wait_time);
if ($msg) $from_network = 1;
}
Took a quick look at this. I agree with removing the indefinite wait, but backlog processing will need to be tested, as with the proposed patch $from_network never changes value. Something like this might capture the intent better:
if ($msg) { {osrf_handle} ->process( $wait_time) ;
# we just popped a message from the backlog queue
# let's see if we can process it
$from_network = 0;
} else {
$msg = $self->
if ($msg) $from_network = 1;
}