So, I've tested both branches on Evergreen 3.0 with OpenSRF 3.0, and the fix works for me. I used a copy of production data and change my username to have a % in it. Without the branches, I could not log in. With them applied, I could.
I've added my sign offs to the branches below, but not pushed because I think we should have a conversation about putting the version that breaks ABI into OpenSRF 3.1. I'd be OK with that and using this non-ABI breaking version in OpenSRF 3.02.
Branch named user/dyrcona/lp-1702978-variadic_get_hates_percent_in_key-SIGNOFF in both working repositories.
So, I've tested both branches on Evergreen 3.0 with OpenSRF 3.0, and the fix works for me. I used a copy of production data and change my username to have a % in it. Without the branches, I could not log in. With them applied, I could.
I've added my sign offs to the branches below, but not pushed because I think we should have a conversation about putting the version that breaks ABI into OpenSRF 3.1. I'd be OK with that and using this non-ABI breaking version in OpenSRF 3.02.
Branch named user/dyrcona/ lp-1702978- variadic_ get_hates_ percent_ in_key- SIGNOFF in both working repositories.
http:// git.evergreen- ils.org/ ?p=working/ OpenSRF. git;a=shortlog; h=refs/ heads/user/ dyrcona/ lp-1702978- variadic_ get_hates_ percent_ in_key- SIGNOFF
http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ dyrcona/ lp-1702978- variadic_ get_hates_ percent_ in_key- SIGNOFF