Comment 3 for bug 867449

Hi,

Thanks for your answer.

> 1. I could have downloaded it and I am using it placed somewhere else.
This patch still allow to manually set the path for wkhtmltopdf.

> 2. We cannot waste system resources searching for any third party lib. It seems it will happen each time report is printed!
This patch will only search the system if no path is defined but even then this is a extremly fast operation and it's done each time you launch a program on *nix.

> 3. I could rename too.

Current code doesn't allow you to have an executable by any other name than 'wkhtmltopdf' anyway

> 4. Its a third party library. Logically, similar to addons-path. So better to configure rather than code.

It's still configuration but done via the PATH environment settings, which is generally the preferred way under *nix. It also allow to configure it once for the whole server than each time you create a new database.

> 5. It might be possible that there is no enough access for the user to access the PATH you wrote.

The PATH is configured in the system, if an user doesn't have access right for one of the directory in your system path it probably mean that there is an error in your system configuration.

I hope I have answered all yours concerns. I don't know the rules for the C2C so I hope I don't break any by re-puting this patch up for consideration.