Comment 3 for bug 784501

Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Hello Stéphane,

Thanks for reporting and providing a patch! You're right about the bug, but I think the issue is greatly mitigated by the fact that if you are using LDAP authentication, you are supposed to manage the authentication policy at the LDAP level. OpenERP only delegates to it. So if you want to disable a user, you should do it at LDAP level. This is why I'm setting the importance to Medium.

However I agree it would be expected by most people that you can prevent a LDAP user from logging in by disabling it in OpenERP as well, so we should fix that.

No question for the last login date of course.

Now we'll have to improve the patch to handle the case where the user is disabled in OpenERP and not in LDAP, as you said, because I think the auto-creation would fail due to uniqueness of logins, leading to stranger errors.

Thanks!