[6.0 series] duplicate modules in addons and addons-extra

[OpenBMS JSC]

The following modules exist both in addons and addons-extra branches (of 6.0.x series). If modules are promoted from addons-extra to addons branch, they should be removed from the addons-extra to avoid confusion and (perhaps) wrong commit/fix.

account_anglo_saxon/
account_coda/
base_crypt/
base_module_doc_rst/
caldav/
hr_evaluation/
hr_payroll/
l10n_ma/
lunch/
marketing/
multi_company/
point_of_sale/
product_expiry/
product_visible_discount/
sale_layout/
sale_margin/
stock_planning/
survey/
thunderbird/
users_ldap/

[Bogdan Stanciu (bstanciu)]

On 28. 04. 11 15:30, Phong Nguyen-Thanh wrote:
> Public bug reported:
>
> The following modules exist both in addons and addons-extra branches (of
> 6.0.x series). If modules are promoted from addons-extra to addons
> branch, they should be removed from the addons-extra to avoid confusion
> and (perhaps) wrong commit/fix.
>
> account_anglo_saxon/
> account_coda/
> base_crypt/
> base_module_doc_rst/
> caldav/
> hr_evaluation/
> hr_payroll/
> l10n_ma/
> lunch/
> marketing/
> multi_company/
> point_of_sale/
> product_expiry/
> product_visible_discount/
> sale_layout/
> sale_margin/
> stock_planning/
> survey/
> thunderbird/
> users_ldap/
>
> ** Affects: openobject-addons
> Importance: Undecided
> Status: New
>
While I think it is a good initiative, last time I had a similar report
I was told I should clean them myself :-))

Additionally, there are 6 modules which are not installable... shouldn't
they be cleared/repaired/parked, too?

[2011-04-27 16:43:44,949][bs_02] WARNING:init:module airport: not
installable, skipped
[2011-04-27 16:43:44,950][bs_02] WARNING:init:module segmentation: not
installable, skipped
[2011-04-27 16:43:44,951][bs_02] WARNING:init:module sale_rebate: not
installable, skipped
[2011-04-27 16:43:44,952][bs_02] WARNING:init:module health: not
installable, skipped
[2011-04-27 16:43:44,959][bs_02] WARNING:init:module l10n_fr_pcg: not
installable, skipped
[2011-04-27 16:43:44,960][bs_02] WARNING:init:module esale_ez: not
installable, skipped
[2011-04-27 16:43:44,961][bs_02] WARNING:init:module hr_holidays_cci:
not installable, skipped

bogdan

[OpenBMS JSC (openbmsjsc)]

I think the current process is that a new (community) module should be placed into addons-extra or addons-community and when it's matured or OpenERP SA decided it would be usefull to get promoted to addons and will include in OPW in the coming release. Thus if OpenERP decide to move, they should make the clean-up and it's even better if they send out the notification.

I think these residual is more likely a result of neglect/oversight in the promotion/release procedure, which should be fixed so that it will reduce the maintenance cost for OpenERP and the community.

[Amit Parik (amit-parik)]

Hello Phong,

You are right the list of modules what you specified in above specification is considered for version specific.
If you deal with the version 6 then you have to consider addons listed bug not the extra addons bugs.

The some modules are comes from extra-addons to addons in version 6 so there is some duplication in addons and extra-addons that's why you can use those module form official addons not from extra-addons.

So if you or anyone from the community would like to work on it, please mark the bug as "In progress" and assign it to yourself (or ask us or anyone from OpenERP Drivers to do it for you). In the mean time, I will mark it as "Won't fix" to indicate that no further progress is expected at the moment.

Hope this will help for you.

Thanks for the understanding!

[OpenBMS JSC (openbmsjsc)]

Amit, I think you misunderstand: what I expect is that OpenERP will reorganize the addons-extra to remove the duplicated modules (which have been moved to official addons), and to establish a process for similar problems in the coming time, as I expect there will be more modules get promoted to the official branch.

This is not a bug related to any particular module, but might be called a "process bug", so that OpenERP and the community can improve its quality process. Thus I suggest to leave the status as "New" until an improved procedure is in place.

Best regards.

[Bogdan Stanciu (bstanciu)]

On 28. 04. 11 16:35, Phong Nguyen-Thanh wrote:
> I think the current process is that a new (community) module should be
> placed into addons-extra or addons-community and when it's matured or
> OpenERP SA decided it would be usefull to get promoted to addons and
> will include in OPW in the coming release. Thus if OpenERP decide to
> move, they should make the clean-up and it's even better if they send
> out the notification.
>
> I think these residual is more likely a result of neglect/oversight in
> the promotion/release procedure, which should be fixed so that it will
> reduce the maintenance cost for OpenERP and the community.
>
Phong,

you should maybe add the module document_webdav_old from extras, as
there is a document_webdav in the addons branch...

thank you,
b

[Christophe Combelles (ccomb)]

There is still a survey directory in the extra-6.0 branch, containing only an i18n directory. This causes a conflict with the other survey directory in the addons. I was obliged to manually remove the extra survey directory to be able to install this module.

This might be caused by a script somewhere, automatically updating the translations?

[OpenBMS JSC (openbmsjsc)]

I think this is likely the result of out of sync between the bazzar and the launchpad translation when the module is moved from addons-extra to addons, so a procedure/checklist should be in place to ensure there is no residual left.

[Amit Parik (amit-parik)]

Hello Phong,

It's fixed in the https://code.launchpad.net/~openerp-commiter/openobject-addons/trunk-extra-addons branch.
5420-5443 <email address hidden>

Revision no: 5420-5443

Thanks