Comment 5 for bug 603100

By the way Carlos, I just found some problems on the sale_tax_included module:

- When creating invoices from orders, the invoice price type is not set as the one from the order (so if the order had included taxes prices, the invoice will not, and they won't match).

- When creating invoices from picking lists, it checks the original orders to check the price type to use, but it matches the pickings with its sale orders by origin (which is user editable free text, OMG!) and name. It does this:
       for picking in self.browse(cursor, user, ids, context=context):
           sale_ids = sale_obj.search(cursor, user, [('name','=',picking.origin)],context=context)
  I think it should do something like this instead (use the many2one reference to the sale order; it is there for a purpose!):
       sale_ids = [picking.sale_id.id for picking in self.browse(cursor, user, ids, context=context) if picking.sale_id]

Maybe I should register a bug report for the sale_tax_include too :(