Comment 9 for bug 528320

Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Comment about the proposed patch: functionally it seems correct to me, but technically why not use the existing test_cancel() method that exists for this purpose, instead of adding one more method with the same code?
Even better, why not wrap the existing test_cancel() method in a check_cancel() method that calls it and raises an error when it can't be cancelled. So instead of having a button that does nothing users would see a meaningful message?