POS does not compute child taxes

[Marc Cassuto (SFL)]

Hi,

POS has its own method to compute taxes in point_of_sale/static/src/js/models.js, lines 508 to 531.

When you've got a tax with dependant child, these children are not taken into account in the calculation.

Here how to check :
* create a new DB*
* add accounting feature and choose Canadian Chart of account, Template for english provinces
* activate pos module
* create a product with the following sales tax : TPSTVQ_SALE; (this product should be set as "Available in the Point of Sale ")
* open a POS session
* sell this product
=> the tax is wrong (set as 100%)

This is critical since it avoids the use of POS in many countries...

regard,
Marc

[Amit Parik (amit-parik)]

Hello Marc,

You are correct. I have tried with the POS order and touchscreen pos both with child taxes.

I have faced the problem on touchscreen pos.

Thank you!

[Rifakat Husen (OpenERP) (rha-openerp)]

Hi Marc,

I would say currently we have kept simple one level tax support for Point of Sale. Children taxes are not supported currently. We have kept it generic so that one can enhance the functionality. It's not only the tax calculation but needs more changes because as soon as it displays the children taxes, it should also display all tax allocation separately, which needs to create some fields and logic.

It looks like an improvement than a bug for me.
For your problem of 100% tax, it might due to configuration of tax as 1.0.
Thanks a lot for your understanding.

Regards,
Rifakat

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

Hi Rifakat,

Is this a joke ? This is a bug which makes the Point of Sales, which is advertised as production ready, totally unusable in contexts where using child taxes is made mandatory by legislation.

[Rifakat Husen (OpenERP) (rha-openerp)]

Hello Alexandre Fayolle,

It's not only about adding or displaying child taxes as of total taxes, but don't you think this will require displaying tax distribution too?
If there are multiple child taxes then in that case how would one knows what is the tax amount for which individual tax as it would only display total. This needs to be discussed further I think.

Thanks a lot for sharing your suggestion,
Rifakat

[Marc Cassuto (SFL) (mcassuto)]

Hello Rifakat,

yes it will have to display all the childs taxes on the ticket too.

In fact, I don't even understand why we are discussing here ?
I have a customer who paid to get its bug resolved; from his point of you it is a bug : tax are properly computed in the accounting module
but not in the pos module...

Regards,
Marc

==
Marc Cassuto, Ing. MBA Itil

SAVOIR-FAIRE LINUX
Consultant solutions ERP
T: 514-276-5468 #180

----- Original Message -----
> From: "Rifakat Husen (OpenERP)" <email address hidden>
> To: "marc cassuto" <email address hidden>
> Sent: Friday, October 4, 2013 8:52:53 AM
> Subject: [Bug 1231574] Re: POS does not compute child taxes
>
> Hello Alexandre Fayolle,
>
> It's not only about adding or displaying child taxes as of total
> taxes, but don't you think this will require displaying tax
> distribution too?
> If there are multiple child taxes then in that case how would one
> knows what is the tax amount for which individual tax as it would
> only display total. This needs to be discussed further I think.
>
> Thanks a lot for sharing your suggestion,
> Rifakat
>
> --
> You received this bug notification because you are subscribed to the
> bug
> report.
> https://bugs.launchpad.net/bugs/1231574
>
> Title:
> POS does not compute child taxes
>
> Status in OpenERP Addons (modules):
> Confirmed
>
> Bug description:
> Hi,
>
> POS has its own method to compute taxes in
> point_of_sale/static/src/js/models.js, lines 508 to 531.
>
> When you've got a tax with dependant child, these children are not
> taken into account in the calculation.
>
> Here how to check :
> * create a new DB*
> * add accounting feature and choose Canadian Chart of account,
> Template for english provinces
> * activate pos module
> * create a product with the following sales tax : TPSTVQ_SALE;
> (this product should be set as "Available in the Point of Sale ")
> * open a POS session
> * sell this product
> => the tax is wrong (set as 100%)
>
> This is critical since it avoids the use of POS in many
> countries...
>
> regard,
> Marc
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openobject-addons/+bug/1231574/+subscriptions
>

[Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903)]

Let's discuss it then.

What is the problem of displaying the tax distribution ? You display one tax, why can't you display more than one ?

If you don't, POS is not production ready here in Canada and you have a problem with your marketing message.

How do you want to solve this ?
1) Update your marketing message
2) Solve this bug

[Rifakat Husen (OpenERP) (rha-openerp)]

I will check what I can do to fix it by minimal way for the stable version. I will get back to you.

[Rifakat Husen (OpenERP) (rha-openerp)]

Hello,
I have fixed POS child tax calculation problem in,
lp:~openerp-dev/openobject-addons/7.0-opw-598610-rha
Revision 9522, <email address hidden>

Please let me know how's the working of the patch at your end.
Regards,
Rifakat

[Marc Cassuto (SFL) (mcassuto)]

Fix is working on my side.

Please have a commit quickly since this is q bug covered by the OE enterprise licence.

Regards,
Marc

==
Marc Cassuto, Ing. MBA Itil

SAVOIR-FAIRE LINUX
Consultant solutions ERP
T: 514-276-5468 #180

----- Original Message -----
> From: "Rifakat Husen (OpenERP)" <email address hidden>
> To: "marc cassuto" <email address hidden>
> Sent: Wednesday, October 23, 2013 1:52:54 AM
> Subject: [Bug 1231574] Re: POS does not compute child taxes
>
> Hello,
> I have fixed POS child tax calculation problem in,
> lp:~openerp-dev/openobject-addons/7.0-opw-598610-rha
> Revision 9522, <email address hidden>
>
> Please let me know how's the working of the patch at your end.
> Regards,
> Rifakat
>
> ** Changed in: openobject-addons
> Status: In Progress => Fix Committed
>
> --
> You received this bug notification because you are subscribed to the
> bug
> report.
> https://bugs.launchpad.net/bugs/1231574
>
> Title:
> POS does not compute child taxes
>
> Status in OpenERP Addons (modules):
> Fix Committed
>
> Bug description:
> Hi,
>
> POS has its own method to compute taxes in
> point_of_sale/static/src/js/models.js, lines 508 to 531.
>
> When you've got a tax with dependant child, these children are not
> taken into account in the calculation.
>
> Here how to check :
> * create a new DB*
> * add accounting feature and choose Canadian Chart of account,
> Template for english provinces
> * activate pos module
> * create a product with the following sales tax : TPSTVQ_SALE;
> (this product should be set as "Available in the Point of Sale ")
> * open a POS session
> * sell this product
> => the tax is wrong (set as 100%)
>
> This is critical since it avoids the use of POS in many
> countries...
>
> regard,
> Marc
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openobject-addons/+bug/1231574/+subscriptions
>

[Marc Cassuto (SFL) (mcassuto)]

hello,

may we have an update on this bug fix ?

This bug is covered by an OE enterprise licence.

Regards,
Marc

==
Marc Cassuto, Ing. MBA Itil

SAVOIR-FAIRE LINUX
Consultant solutions ERP
T: 514-276-5468 #180

----- Original Message -----
> From: "Marc Cassuto" <email address hidden>
> To: "Bug 1231574" <email address hidden>
> Sent: Wednesday, October 23, 2013 8:56:11 AM
> Subject: Re: [Bug 1231574] Re: POS does not compute child taxes
>
> Fix is working on my side.
>
> Please have a commit quickly since this is q bug covered by the OE
> enterprise licence.
>
> Regards,
> Marc
>
> ==
> Marc Cassuto, Ing. MBA Itil
>
> SAVOIR-FAIRE LINUX
> Consultant solutions ERP
> T: 514-276-5468 #180
>
> ----- Original Message -----
> > From: "Rifakat Husen (OpenERP)" <email address hidden>
> > To: "marc cassuto" <email address hidden>
> > Sent: Wednesday, October 23, 2013 1:52:54 AM
> > Subject: [Bug 1231574] Re: POS does not compute child taxes
> >
> > Hello,
> > I have fixed POS child tax calculation problem in,
> > lp:~openerp-dev/openobject-addons/7.0-opw-598610-rha
> > Revision 9522, <email address hidden>
> >
> > Please let me know how's the working of the patch at your end.
> > Regards,
> > Rifakat
> >
> > ** Changed in: openobject-addons
> > Status: In Progress => Fix Committed
> >
> > --
> > You received this bug notification because you are subscribed to
> > the
> > bug
> > report.
> > https://bugs.launchpad.net/bugs/1231574
> >
> > Title:
> > POS does not compute child taxes
> >
> > Status in OpenERP Addons (modules):
> > Fix Committed
> >
> > Bug description:
> > Hi,
> >
> > POS has its own method to compute taxes in
> > point_of_sale/static/src/js/models.js, lines 508 to 531.
> >
> > When you've got a tax with dependant child, these children are
> > not
> > taken into account in the calculation.
> >
> > Here how to check :
> > * create a new DB*
> > * add accounting feature and choose Canadian Chart of account,
> > Template for english provinces
> > * activate pos module
> > * create a product with the following sales tax : TPSTVQ_SALE;
> > (this product should be set as "Available in the Point of Sale ")
> > * open a POS session
> > * sell this product
> > => the tax is wrong (set as 100%)
> >
> > This is critical since it avoids the use of POS in many
> > countries...
> >
> > regard,
> > Marc
> >
> > To manage notifications about this bug go to:
> > https://bugs.launchpad.net/openobject-addons/+bug/1231574/+subscriptions
> >
>

[Josh Beach (jb-6)]

Hello,

I have tested this fix and it does not work. I have two child taxes (One 5% and one 10%) and the final tax computation is incorrect. It does however work correctly with a single child tax of 15%. There must be an incorrect compound interest calculation.

Also, even when using the single child tax, the end order is calculated incorrectly and different than the calculation within the POS (Point of Sale > Daily Operations > Orders)

Regards,
Josh

[Martin Auger (martin-auger)]

Ok greate improvement... tax computation look good... But we must have the details of the taxs on the POS screen and on the receipt between subtotal and total.

We can't do nothing right now with the POS module in Canada because this is incomplete... So the OpenERP customers who was thinking that POS was good for them, they do error...

Do you think you will do something for that or we just need to forget to use this module in Canada?

Thx,

Martin

[Mathieu Fortin (mathfortin)]

I was planning on using OpenERP/Odoo and this is a major issue.

Anyone have found a way of displaying the proper tax rates on the invoices ?

I did apply the patch, the tax rate is OK but there is no clear separation in the GST and QST. I have products that I sell that do not apply to QST and I need to display the details to the end customers.

[philippe (anonimous-6661)]

I'm trying to fix child tax problem on my POS (odoo v8), how can I fix this?

[Pascal Tremblay (e-pt)]

Idem for me in Odoo v. 8. How to fix? Please

[Guillaume Bard (bardbq)]

Need a fix vor Odoo 8 as well. This is one of the main feature of Odoo that needs to be working as advertised.

[Jean-Nicolas Brunet (jnbrunet2000)]

Any update with this bug on Odoo 8? This is blocking for us, we can't use the POS without children taxes. We are waiting for the fix release in order to use Odoo. Thank you!

[Guillaume Bard (bardbq)]

That's right, we can't do anything without a fix for the POS!

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

v8 is tracked on github. I think the corresponding issue is https://bugs.launchpad.net/openobject-addons/+bug/1231574

[Rifakat Husen (OpenERP) (rha-openerp)]

https://github.com/odoo/odoo/issues/1515 :)

[Rifakat Husen (OpenERP) (rha-openerp)]

and pull request, https://github.com/odoo/odoo/pull/1835

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

Sorry, wrong copy paste: https://github.com/odoo/odoo/pull/1835

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

@rha-openerp yes... Unfortunately the branch is in conflict with the current head, and Antony Lesuisse has made no updates in the past two months...