[6.1, 7.0, trunk] Text to email parsing incomplete + needs to be unified

[Etienne Hirt]

While using 6.1 mail_message to_email function I found that it does not
cope with all the possible names in the emaillist.

example: '[e-mail]' <[e-mail]>, ([e-mail]) <[e-mail]>, "'[e-mail]'" <[e-mail]>, etc

The regexp in the function to_email of mail/mail_message.py should be enhanced that it also removes ", () and
even if the allowed '.

----

Note: for more details and trunk cases see also bug 1199386

[Etienne Hirt (hirt)]

Attach patch (from svn)

[Twinkle Christian(OpenERP) (tch-openerp)]

Hello Etienne,

Currently, I have checked your Issue with 6.1 as well with 7.0 and trunk, but this issue is affected only in 6.1 not in 7.0 and in trunk and It is not a blocking Issue. So, For that we can not consider this issue.

If you have a support and maintenance contract with us then you can contact with our OPW team at <email address hidden> ,they will definitely help you.

Thank you!

[Etienne Hirt (hirt)]

Dear Christian,

thanks for checking. I understand that this issue affecting only 6.0 and
6.1 is not corrected by openerp.

However, please set the bug to won't fix instead of invalid

Thanks

Etienne

On 20.05.2013 15:26, Twinkle Christian(OpenERP) wrote:
> Hello Etienne,
>
> Currently, I have checked your Issue with 6.1 as well with 7.0 and
> trunk, but this issue is affected only in 6.1 not in 7.0 and in trunk
> and It is not a blocking Issue. So, For that we can not consider this
> issue.
>
> If you have a support and maintenance contract with us then you can
> contact with our OPW team at <email address hidden> ,they will definitely
> help you.
>
> Thank you!
>
>
> ** Changed in: openobject-addons
> Status: New => Invalid
>

[Olivier Dony (Odoo) (odo-openerp)]

Hi Etienne,

Even though the bug could initially not be reproduced on OpenERP 7.0, we have reproduced similar cases where the current parsing fails to extract emails. Using the standard email.utils.getaddresses is indeed a better way to implement the parsing, but it does require extra precautions. `getaddresses()` will insert empty strings in the results when parsing fails, even partially, and it will also return invalid addresses if nothing better can be extracted (e.g. ones without even the '@' character that is strictly required by RFC2822). This is presumably a safer default for the stdlib but we need somewhat stricter parsing in OpenERP.

As a result we have adapted the patch of your merge proposal for OpenERP 7.0, with extra checks on the results, and added corresponding unit tests. This has been merged in server 7.0 at revision 5198 revid <email address hidden>

Thanks for reporting the bug and submitting a patch!

[Olivier Dony (Odoo) (odo-openerp)]

Note that the bug initially affected Addons in 6.1, but the corresponding code moved to the server in 7.0, so technically the bug affects Server 7.0.

A small patch to the mail-related tests in Addons 7.0 was also necessary to keep them green (they were misusing the email_split method), and applied at rev 9760 rev-id: <email address hidden>

[Olivier Dony (Odoo) (odo-openerp)]

For 7.0 the bug can be considered fixed as the main `tools.email_split` is now correct. For trunk the bug is still open as additional regex parsing need to corrected - it perhaps requires the introduction of new utility methods.