Comment 128 for bug 1160365

Revision history for this message
Fabien (Open ERP) (fp-tinyerp) wrote : Re: [Bug 1160365] Re: [7.0] incorrect handling of contact/companies for invoicing and related purposes

Ana,

Thanks for taking the time to test the proposition. I put some
explanations bellow.

On 12/04/13 22:40, Ana Juaristi Olalde wrote:
> OK... Testing as asked by Fabien in Runbot.
>
> Sale order:
> Customer ACME Company Walt disney studios 444444444 Orlando, FL 33333 United States
> Invoice Address John Doe for Acme Company (ACME Company) John Doe Home Address 3838383838 Myhome, FL 2222 United States
> Delivery Address Agrolait 69 rue de Namur 1300 Wavre Belgium

I checked your record on runbot. You did two mistakes as shown in the
screenshot in attachment:
   - no need to write "John Doe for ACME" in the name as ACME is always
linked to John Doe
   - you can not write the Home address in the field address of "John
Doe, ACME". "John Doe, ACME"'s data must be the data of John Doe at
ACME: <email address hidden>, address of ACME where john doe is working, ...

> It seems quite extrange to be allowed sending goods to Agrolait when
> it's another partner, but... extremly it could be. (Bug easily can fixed
> including right domain on sale order)

Yes, this has to be discussed. This feature is required by a few
companies and was available with the base_partner_relation module in
v6.1. In a default installation, the user do not have the possibility to
set a different delivery address than the order address as you have to
check the option "Allow using a different delivery and invoicing
address". Both approaches (domain or not) are ok for me, they all have
theirs pros and cons.

> Going further:
> Picking is correctly set to Agrolait. Sales order printing is correctly printed but is showing also John Doe's home address.

Because that's what you wrongly recorded.

Note that if you do the same mistake in v6.1 (recording the Home address
on a contact of a company), you get exactly the same, wrong, behaviour.

> Next step:
> Create invoice from picking:
> Customer John Doe for Acme Company (ACME Company) John Doe Home Address 3838383838 Myhome, FL 2222 United States
> FOR ME THIS IS TOTALLY WRONG. INVOICE CONTACT is John DOE, but... INVOICE ADDRESS SHOULD BE the one from ACME
> What am I doing wrong here?

Because that's what you wrongly recorded.

Note that if you do the same mistake in v6.1 (recording the Home address
on a contact of a company), you get exactly the same behaviour.

So, according to your test, the result looks exactly the same in v6.1
and v7.

> Conclusions:
> 1. I can not register contact with their own addresses or contact fields, If I want, I have got to duplicate them but... what for? If I can not use them on documents?

By default, whether you use v6.1 or v7, contacts have only one address
associated to them. If it's a contact of a company, it has to be the
address of the company, if it's a contact not linked to a company, it
can be it's home address. If you want two addresses on a contact (a home
and a company one), you have to create two records or install the
base_contact module.

Note that in v7, we will improve the useability by changing the label
"Address" to "Company Address" to avoid this misunderstanding when
recording contacts. I did it on runbot to help you reproduce the flow.

> 2. With the simple, real example, I can confirm that WE DO NEED at less Partner-Address table, even if in your new aproach there is only a single partners table to register also contacts/employess. I mean...

Can you test the same example in v6.1? You will see that it's exactly
the same. (if you record wrong data, you get wrong results)

I think that part of the confusion come from the fact that you expect to
use base_contact but this module is not installed on this branch. It's
in another branch ( 7.0-base-contact-xal) on runbot.

I hope these clarifications help you understand the model and that the
results are not different than in v6.1.

Thanks for taking the time to test,

Fabien