[Trunk/7.0]: Returning products causing credit - debit value error

[Cats&Dogs]

Hello,

Also tested on latest runbot for 7.0 (built 3921)

Crete some sales in one pos session.
When you return a product using the Point of Sales - Orders list. Choose a previous POS order ref of that day, return a product, pay it back (it proposes a negative saldo which seems to be correct).

At the end of your session when you want to close and post your session to the sales journal it gives you an error:

"Constraint Error - Wrong credit or debit value in accounting entry !"

When you have a session without returning products it seems to work fine, even with taking money in or out your session using the corresponding buttons.

[Cats&Dogs (catsanddogs)]

Hello,

I've tested this, when I re-activate the function "Group Journal Items" I still get the error message. But when I deactivate the "Group Journal Items" it is working. But this was already working before the changes...

[Ravi Gohil (OpenERP) (rgo-openerp)]

Hi GrtSrkn,

> I've tested this, when I re-activate the function "Group Journal Items" I still get the error message.

Would you please double check that the patch from the above branch is applied properly and you've restarted the OpenERP server after applying the patch?

If you are still facing this issue, please share some screenshots or a small video of the steps you followed.

Thanks.

[Francisco Martinez (pxntium)]

Hi Ravi,
I applied the patch described here:
http://bazaar.launchpad.net/~openerp-dev/openobject-addons/7.0-opw-586526-rgo/revision/8839#point_of_sale/point_of_sale.py

Restart OpenERP and when I try to close the session the same error occurs.

Regards
Fran

2013/3/14 Ravi Gohil (OpenERP) <email address hidden>

> Hi GrtSrkn,
>
> > I've tested this, when I re-activate the function "Group Journal
> Items" I still get the error message.
>
> Would you please double check that the patch from the above branch is
> applied properly and you've restarted the OpenERP server after applying
> the patch?
>
> If you are still facing this issue, please share some screenshots or a
> small video of the steps you followed.
>
> Thanks.
>
> --
> You received this bug notification because you are subscribed to a
> duplicate bug report (1138698).
> https://bugs.launchpad.net/bugs/1127114
>
> Title:
> [Trunk/7.0]: Returning products causing credit - debit value error
>
> Status in OpenERP Addons (modules):
> Fix Committed
>
> Bug description:
> Hello,
>
> Also tested on latest runbot for 7.0 (built 3921)
>
> Crete some sales in one pos session.
> When you return a product using the Point of Sales - Orders list. Choose
> a previous POS order ref of that day, return a product, pay it back (it
> proposes a negative saldo which seems to be correct).
>
> At the end of your session when you want to close and post your
> session to the sales journal it gives you an error:
>
> "Constraint Error - Wrong credit or debit value in accounting entry !"
>
> When you have a session without returning products it seems to work
> fine, even with taking money in or out your session using the
> corresponding buttons.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openobject-addons/+bug/1127114/+subscriptions
>

[Cats&Dogs (catsanddogs)]

Hello Ravi,

The patches are done, server restarted with update on all modules. The steps are still the same like a regular POS situation. Once you have a negative saldo due to a returning products procedure where the end result is negative (= refund from your cash journal) it is giving me this error.

I've been working without the function "Group Journal Items"on the POS activated. I can close the POS session without this error. What I noticed might be the problem of this error. When I close the session and go to the booking details, I noticed that the refund amount is not correctly booked in the sales journal. See my 2 screenshots.

The Tax amount is not registered in the refund tax account (64) but in account (54) and the value is save negative. The refund amount is also negative but these are correctly booked in the tax account of refunds (49).

Result is a wrong tax report in accounting. Took me all weekend to find it, I hope to be ready before 20th march this week with editing all refund entries...

[Ravi Gohil (OpenERP) (rgo-openerp)]

Hi GrtSrkn, Francisco Martinez,

Sorry for the inconvenience.

There was a small mistake in the initial patch which I fixed and pushed the updated solution in the above branch. Now, you should be able to close the POS session.

Would you please test it again.

Thanks.

[Francisco Martinez (pxntium)]

Hi Ravi,
it's worked for me. Thx!

Best Regards
Fran

2013/3/19 Ravi Gohil (OpenERP) <email address hidden>

> Hi GrtSrkn, Francisco Martinez,
>
> Sorry for the inconvenience.
>
> There was a small mistake in the initial patch which I fixed and pushed
> the updated solution in the above branch. Now, you should be able to
> close the POS session.
>
> Would you please test it again.
>
> Thanks.
>
> --
> You received this bug notification because you are subscribed to a
> duplicate bug report (1138698).
> https://bugs.launchpad.net/bugs/1127114
>
> Title:
> [Trunk/7.0]: Returning products causing credit - debit value error
>
> Status in OpenERP Addons (modules):
> Fix Committed
>
> Bug description:
> Hello,
>
> Also tested on latest runbot for 7.0 (built 3921)
>
> Crete some sales in one pos session.
> When you return a product using the Point of Sales - Orders list. Choose
> a previous POS order ref of that day, return a product, pay it back (it
> proposes a negative saldo which seems to be correct).
>
> At the end of your session when you want to close and post your
> session to the sales journal it gives you an error:
>
> "Constraint Error - Wrong credit or debit value in accounting entry !"
>
> When you have a session without returning products it seems to work
> fine, even with taking money in or out your session using the
> corresponding buttons.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openobject-addons/+bug/1127114/+subscriptions
>

[Vincent Michaud (vincent-michaud)]

Hi Ravi,
it's worked for me. Thx!

Best Regards

[Cats&Dogs (catsanddogs)]

Also here it is working, thnx

I start a new bug for my other remarks about the accounting entries this closing feature is creating, they are wrong and saved negative...

[Francisco Martinez (pxntium)]

Hi,
Since I applied the patch, I can enable the "Group journal items", and I
can close the session. The problem now is the large time to close the
session. When I have about 100 orders and I want to close the session, the
system takes ~4minutes to close the session. The same operation has take
30segs before the patch.
It's possible that now the system is not grouping the items?
I think this option group the lines for the same session and product in
only one row at table "account_move_line", and If I surf through the table
I can see that is not.

Regards.
Fran

2013/3/19 Francisco Martínez <email address hidden>

> Hi Ravi,
> it's worked for me. Thx!
>
> Best Regards
> Fran
>
>
>
> 2013/3/19 Ravi Gohil (OpenERP) <email address hidden>
>
> Hi GrtSrkn, Francisco Martinez,
>>
>> Sorry for the inconvenience.
>>
>> There was a small mistake in the initial patch which I fixed and pushed
>> the updated solution in the above branch. Now, you should be able to
>> close the POS session.
>>
>> Would you please test it again.
>>
>> Thanks.
>>
>> --
>> You received this bug notification because you are subscribed to a
>> duplicate bug report (1138698).
>> https://bugs.launchpad.net/bugs/1127114
>>
>> Title:
>> [Trunk/7.0]: Returning products causing credit - debit value error
>>
>> Status in OpenERP Addons (modules):
>> Fix Committed
>>
>> Bug description:
>> Hello,
>>
>> Also tested on latest runbot for 7.0 (built 3921)
>>
>> Crete some sales in one pos session.
>> When you return a product using the Point of Sales - Orders list.
>> Choose a previous POS order ref of that day, return a product, pay it back
>> (it proposes a negative saldo which seems to be correct).
>>
>> At the end of your session when you want to close and post your
>> session to the sales journal it gives you an error:
>>
>> "Constraint Error - Wrong credit or debit value in accounting entry !"
>>
>> When you have a session without returning products it seems to work
>> fine, even with taking money in or out your session using the
>> corresponding buttons.
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/openobject-addons/+bug/1127114/+subscriptions
>>
>
>

[Francisco Martinez (pxntium)]

Hi Ravi,
I have confirmed that the long closing session time is produced by this patch. Follow a example:

I have a session with 181 orders (sales in a day). If I try to close this session with the patch applied, the closing process takes over 7 minutes to close. If I try to close without the patch applied (downgrading the point_of_sale.py), the closing process takes only 57 secs. It's a bigger difference.

I have open a new bug #1162369 with this problem.

Thanks in advance
Fran

[Cats&Dogs (catsanddogs)]

Hello,

We also have experienced long closing time for a POS session when you have some orders on a single session.

@Francisco; I assume that when you didn't apply the patch you have disabled the function "Group Journal Items" again.
@ Ravi; What does this setting stands for? Because I see no differences between the posts if you enable/disable this setting.

[Francisco Martinez (pxntium)]

Hi,
yes, when I didn't apply the patch I have disabled the "Group Journal
Items" option, If I want to avoid error messages.

Regards
Fran

2013/4/1 GrtSrkn <email address hidden>

> Hello,
>
> We also have experienced long closing time for a POS session when you
> have some orders on a single session.
>
> @Francisco; I assume that when you didn't apply the patch you have
> disabled the function "Group Journal Items" again.
> @ Ravi; What does this setting stands for? Because I see no differences
> between the posts if you enable/disable this setting.
>
> --
> You received this bug notification because you are subscribed to a
> duplicate bug report (1138698).
> https://bugs.launchpad.net/bugs/1127114
>
> Title:
> [Trunk/7.0]: Returning products causing credit - debit value error
>
> Status in OpenERP Addons (modules):
> Fix Committed
>
> Bug description:
> Hello,
>
> Also tested on latest runbot for 7.0 (built 3921)
>
> Crete some sales in one pos session.
> When you return a product using the Point of Sales - Orders list. Choose
> a previous POS order ref of that day, return a product, pay it back (it
> proposes a negative saldo which seems to be correct).
>
> At the end of your session when you want to close and post your
> session to the sales journal it gives you an error:
>
> "Constraint Error - Wrong credit or debit value in accounting entry !"
>
> When you have a session without returning products it seems to work
> fine, even with taking money in or out your session using the
> corresponding buttons.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openobject-addons/+bug/1127114/+subscriptions
>

[Francisco Martinez (pxntium)]

Hello,
In addition to the last comments, another problem is presented when the patch is applied:

The Journal Items are not grouped.

Regards
Fran

[Ravi Gohil (OpenERP) (rgo-openerp)]

Hello Francisco,

Thanks for pointing this issue.

Sorry for the late reply. I've updated the branch, lp:~openerp-dev/openobject-addons/7.0-opw-586526-rgo, that will now correctly group the journal items.

A fix was merged by http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/revision/8972 which should solve the issue of long time taken while closing a PoS session.

Would you please test again with this branch and share your views on it.

Thanks.

[Francisco Martinez (pxntium)]

Hi Ravi,
I have downloaded the new point_of_sale.py file and copy into the
point_of_sale addons directory. Restart the server and, when I try to close
session, I have the following error message:

*Constraint Error*
*Wrong credit or debit value in accounting entry !*

I have a refund on this session. The problem its the same that before of
the first patch.

Thnks!
Fran

2013/4/22 Ravi Gohil (OpenERP) <email address hidden>

> Hello Francisco,
>
> Thanks for pointing this issue.
>
> Sorry for the late reply. I've updated the branch, lp:~openerp-dev
> /openobject-addons/7.0-opw-586526-rgo, that will now correctly group the
> journal items.
>
> A fix was merged by http://bazaar.launchpad.net/~openerp/openobject-
> addons/7.0/revision/8972 which should solve the issue of long time taken
> while closing a PoS session.
>
> Would you please test again with this branch and share your views on it.
>
> Thanks.
>
> --
> You received this bug notification because you are subscribed to a
> duplicate bug report (1138698).
> https://bugs.launchpad.net/bugs/1127114
>
> Title:
> [Trunk/7.0]: Returning products causing credit - debit value error
>
> Status in OpenERP Addons (modules):
> Fix Committed
>
> Bug description:
> Hello,
>
> Also tested on latest runbot for 7.0 (built 3921)
>
> Crete some sales in one pos session.
> When you return a product using the Point of Sales - Orders list. Choose
> a previous POS order ref of that day, return a product, pay it back (it
> proposes a negative saldo which seems to be correct).
>
> At the end of your session when you want to close and post your
> session to the sales journal it gives you an error:
>
> "Constraint Error - Wrong credit or debit value in accounting entry !"
>
> When you have a session without returning products it seems to work
> fine, even with taking money in or out your session using the
> corresponding buttons.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openobject-addons/+bug/1127114/+subscriptions
>

[Ravi Gohil (OpenERP) (rgo-openerp)]

Hi,

I tested this again by closing a PoS session which has a refund and I was successfully able to close it, for your reference, I am attaching few screenshots from the test I did on my branch(7.0-opw-586526-rgo) on http://runbot.openerp.com/ You can also perform your tests on same branch on runbot.

Would you please go through it and point me if I missed something.

Thanks.

[Francisco Martinez (pxntium)]

Hi Ravi,
I think I'm doing something wrong:

   1. I have downloaded the point_of_sale.py from the rev 8792
   2. Restarted the Openerp server
   3. Create a new session in POS
   4. Making 3 orders
   5. Refund the second order
   6. Try to close the session, and I have the same error

The log says:
2013-04-23 21:02:56,825 10212 ERROR None openerp.sql_db: bad query: insert
into "account_move_line"
(id,"account_id","company_id","currency_id","period_id","date_created","date","partner_id","move_id","blocked","tax_amount","product_id","centralisation","journal_id","name","tax_code_id","credit","state","debit","amount_currency","ref","quantity",create_uid,create_date,write_uid,write_date)
values
(164226,1158,'1',NULL,'5','2013-04-23','2013-04-23',NULL,43162,'False','5.64',863,'normal','1','PIRULETA
ARBOL
LECHE',8,'2.82','draft','2.82','0.00','POS/2013/04/29332','0.00',15,(now()
at time zone 'UTC'),15,(now() at time zone 'UTC'))
Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.7/openerp/sql_db.py", line 227, in
execute
    res = self._obj.execute(query, params)
IntegrityError: el nuevo registro para la relación «account_move_line»
viola la restricción check «account_move_line_credit_debit1»

2013-04-23 21:02:56,826 10212 ERROR None openerp.tools.safe_eval: Cannot
eval u'wkf_action_close()'
Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.7/openerp/tools/safe_eval.py", line 241,
in safe_eval
    return eval(test_expr(expr, _SAFE_OPCODES, mode=mode), globals_dict,
locals_dict)
  File "", line 1, in <module>
  File "/usr/lib/pymodules/python2.7/openerp/osv/orm.py", line 374, in
function_proxy
    return attr(self._cr, self._uid, [self._id], *args, **kwargs)
  File "/usr/share/pyshared/openerp/addons/point_of_sale/point_of_sale.py",
line 435, in wkf_action_close
    self._confirm_orders(cr, uid, ids, context=context)
  File "/usr/share/pyshared/openerp/addons/point_of_sale/point_of_sale.py",
line 454, in _confirm_orders
    self.pool.get('pos.order')._create_account_move_line(cr, uid,
order_ids, session, move_id, context=context)
  File "/usr/share/pyshared/openerp/addons/point_of_sale/point_of_sale.py",
line 1110, in _create_account_move_line
    self.pool.get("account.move").write(cr, uid, [move_id],
{'line_id':all_lines}, context=context)
  File "/usr/share/pyshared/openerp/addons/account/account.py", line 1339,
in write
    result = super(account_move, self).write(cr, uid, ids, vals, c)
  File "/usr/lib/pymodules/python2.7/openerp/osv/orm.py", line 4180, in
write
    result += self._columns[field].set(cr, self, id, field, vals[field],
user, context=rel_context) or []
  File "/usr/lib/pymodules/python2.7/openerp/osv/fields.py", line 557, in
set
    id_new = obj.create(cr, user, act[2], context=context)
  File "/usr/share/pyshared/openerp/addons/account/account_move_line.py",
line 1229, in create
    result = super(account_move_line, self).create(cr, uid, vals,
context=context)
  File "/usr/lib/pymodules/python2.7/openerp/osv/orm.py", line 4436, in
create
    cr.execute('insert into "'+self._table+'" (id'+upd0+") values
("+str(id_new)+upd1+')', tuple(upd2))
  File "/usr/lib/pymodules/python2.7/openerp/sql_d...

[Ravi Gohil (OpenERP) (rgo-openerp)]

Hello Fran,

> 1. I have downloaded the point_of_sale.py from the rev 8792

(I will assume 8792 as 8972), fix landed on this revision solves the issue of long time taken when closing the PoS session.

The main issue can be solved by apply the fix from this branch. Would you please try again copying http://bazaar.launchpad.net/~openerp-dev/openobject-addons/7.0-opw-586526-rgo/view/head:/point_of_sale/point_of_sale.py and follow the same procedure and let me know whether you have your issue solved or not.

Thanks.

[Francisco Martinez (pxntium)]

Hi ,
Yes, I want to say 8972, sorry.
I will test it tonight and forward to you the results.

Thanks!
Fran
 El 24/04/2013 08:41, "Ravi Gohil (OpenERP)" <email address hidden>
escribió:

> Hello Fran,
>
> > 1. I have downloaded the point_of_sale.py from the rev 8792
>
> (I will assume 8792 as 8972), fix landed on this revision solves the
> issue of long time taken when closing the PoS session.
>
> The main issue can be solved by apply the fix from this branch. Would
> you please try again copying http://bazaar.launchpad.net/~openerp-dev
> /openobject-
> addons/7.0-opw-586526-rgo/view/head:/point_of_sale/point_of_sale.py and
> follow the same procedure and let me know whether you have your issue
> solved or not.
>
> Thanks.
>
> --
> You received this bug notification because you are subscribed to a
> duplicate bug report (1138698).
> https://bugs.launchpad.net/bugs/1127114
>
> Title:
> [Trunk/7.0]: Returning products causing credit - debit value error
>
> Status in OpenERP Addons (modules):
> Fix Committed
>
> Bug description:
> Hello,
>
> Also tested on latest runbot for 7.0 (built 3921)
>
> Crete some sales in one pos session.
> When you return a product using the Point of Sales - Orders list. Choose
> a previous POS order ref of that day, return a product, pay it back (it
> proposes a negative saldo which seems to be correct).
>
> At the end of your session when you want to close and post your
> session to the sales journal it gives you an error:
>
> "Constraint Error - Wrong credit or debit value in accounting entry !"
>
> When you have a session without returning products it seems to work
> fine, even with taking money in or out your session using the
> corresponding buttons.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openobject-addons/+bug/1127114/+subscriptions
>

[Francisco Martinez (pxntium)]

Hi Ravi!
YES, it solved the problem! I'm looking forward to your next instructions...

Best regards
Fran

2013/4/24 Francisco Martínez <email address hidden>

> Hi ,
> Yes, I want to say 8972, sorry.
> I will test it tonight and forward to you the results.
>
> Thanks!
> Fran
> El 24/04/2013 08:41, "Ravi Gohil (OpenERP)" <email address hidden>
> escribió:
>
> Hello Fran,
>>
>> > 1. I have downloaded the point_of_sale.py from the rev 8792
>>
>> (I will assume 8792 as 8972), fix landed on this revision solves the
>> issue of long time taken when closing the PoS session.
>>
>> The main issue can be solved by apply the fix from this branch. Would
>> you please try again copying http://bazaar.launchpad.net/~openerp-dev
>> /openobject-
>> addons/7.0-opw-586526-rgo/view/head:/point_of_sale/point_of_sale.py and
>> follow the same procedure and let me know whether you have your issue
>> solved or not.
>>
>> Thanks.
>>
>> --
>> You received this bug notification because you are subscribed to a
>> duplicate bug report (1138698).
>> https://bugs.launchpad.net/bugs/1127114
>>
>> Title:
>> [Trunk/7.0]: Returning products causing credit - debit value error
>>
>> Status in OpenERP Addons (modules):
>> Fix Committed
>>
>> Bug description:
>> Hello,
>>
>> Also tested on latest runbot for 7.0 (built 3921)
>>
>> Crete some sales in one pos session.
>> When you return a product using the Point of Sales - Orders list.
>> Choose a previous POS order ref of that day, return a product, pay it back
>> (it proposes a negative saldo which seems to be correct).
>>
>> At the end of your session when you want to close and post your
>> session to the sales journal it gives you an error:
>>
>> "Constraint Error - Wrong credit or debit value in accounting entry !"
>>
>> When you have a session without returning products it seems to work
>> fine, even with taking money in or out your session using the
>> corresponding buttons.
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/openobject-addons/+bug/1127114/+subscriptions
>>
>

[Francisco Martinez (pxntium)]

Hi,
with the last code it works fine. Please, can you say whats the changes?

Thanks in advance

Fran

2013/4/24 Francisco Martínez <email address hidden>

> Hi Ravi!
> YES, it solved the problem! I'm looking forward to your next
> instructions...
>
> Best regards
> Fran
>
>
>
> 2013/4/24 Francisco Martínez <email address hidden>
>
>> Hi ,
>> Yes, I want to say 8972, sorry.
>> I will test it tonight and forward to you the results.
>>
>> Thanks!
>> Fran
>> El 24/04/2013 08:41, "Ravi Gohil (OpenERP)" <email address hidden>
>> escribió:
>>
>> Hello Fran,
>>>
>>> > 1. I have downloaded the point_of_sale.py from the rev 8792
>>>
>>> (I will assume 8792 as 8972), fix landed on this revision solves the
>>> issue of long time taken when closing the PoS session.
>>>
>>> The main issue can be solved by apply the fix from this branch. Would
>>> you please try again copying http://bazaar.launchpad.net/~openerp-dev
>>> /openobject-
>>> addons/7.0-opw-586526-rgo/view/head:/point_of_sale/point_of_sale.py and
>>> follow the same procedure and let me know whether you have your issue
>>> solved or not.
>>>
>>> Thanks.
>>>
>>> --
>>> You received this bug notification because you are subscribed to a
>>> duplicate bug report (1138698).
>>> https://bugs.launchpad.net/bugs/1127114
>>>
>>> Title:
>>> [Trunk/7.0]: Returning products causing credit - debit value error
>>>
>>> Status in OpenERP Addons (modules):
>>> Fix Committed
>>>
>>> Bug description:
>>> Hello,
>>>
>>> Also tested on latest runbot for 7.0 (built 3921)
>>>
>>> Crete some sales in one pos session.
>>> When you return a product using the Point of Sales - Orders list.
>>> Choose a previous POS order ref of that day, return a product, pay it back
>>> (it proposes a negative saldo which seems to be correct).
>>>
>>> At the end of your session when you want to close and post your
>>> session to the sales journal it gives you an error:
>>>
>>> "Constraint Error - Wrong credit or debit value in accounting entry !"
>>>
>>> When you have a session without returning products it seems to work
>>> fine, even with taking money in or out your session using the
>>> corresponding buttons.
>>>
>>> To manage notifications about this bug go to:
>>> https://bugs.launchpad.net/openobject-addons/+bug/1127114/+subscriptions
>>>
>>
>

[Ravi Gohil (OpenERP) (rgo-openerp)]

Hi Francisco,

You can find the last changes on this revision, http://bazaar.launchpad.net/~openerp-dev/openobject-addons/7.0-opw-586526-rgo/revision/9049

Thanks.

[Martin Trigaux (OpenERP) (mat-openerp)]

Hello folks,

We have integrated changes into openerp fixing this issue.
revno: 9269
revision-id: <email address hidden>

Thanks for the report

Regards

[[e-mail] (engkim-ang)]

Hi, i had download the point_of_sale.py and i had restart the server but i still get the same error message.

[[e-mail] (engkim-ang)]

hi so sorry i working now, because just now i had updated the wrong file.