Comment 4 for bug 1013229

Hello Reader,

On a very first note, thanks to Edgar Rivero who noticed this out and brought into attention.

This is a real bug when audittrail is supposed to audit the model on which have set 'action' (log action) to be audited.

As a rule of thumb, system is supposed to skip some methods which are not going to alter any data such as name_get, name_search, default_get, etc.

Among such methods, read_group has been forgotten by audittrail.

You won't face any error if you do a group by on audited model( consider any example like partner). But if you do a group by on a model with some domains(any filter is pressed or a custom search applied like name ilike 'ax' any comfortable search), system is supposed to pass domain as the very first argument and at the end of audittrail,it always expects a set of ids to be read(read as red), causing into a traceback as shown by Edgar.

EXAMPLE : Subscribe rule for Partner, log action. Do a simple groupby after clicking clear--> No error. Click any filter or do any search --> You will face an error which would say the DOMAIN is supposedly set as IDS for read() call.

Hence, in future if any method is added/edited in ORM, we have to make sure that the first argument if not IDS, should either be skipped for audittrail or managed as a special case(just like create).

This should surely help.

Regards,
Serpent Consulting Services.
http://www.serpentcs.com