Comment 3 for bug 882819

Revision history for this message
Meinert Jordan (m2j) wrote :

Some days ago I've had a look into this. The basic problem is, that the file names in zip-files have no defined encoding.
We could use chardet, but it is not relyable for such short strings (even though wrong detection does not need to cause problems).

My approach would be to ignore the filenames and derive new filenames from the string stored in the theme XML.
This would works fine for now. As soon we want to store multiple files of the one type in the same theme it is not trivial anymore to assign the data to the generated filenames.

To be future proove we either have to restrict the filenames of additional files inside a theme or use the proposed solution only for 1.x themes while expecting filenames in 2.x themes being utf8 encoded.

Which one of these options should we prefere?