[7.0] pressing sub-view button causes TypeError in client JS

[Isaac Richter]

I was trying to add a tree subview to an existing form (in this case, embedded within a <page>), and discovered that pressing the buttons that are in the tree caused the client to emit "TypeError: self.ViewManager.ActionManager.__parentedParent.menu is undefined"at http://server-address/web/static/src/js/views.js:1373. The line in question is : self.ViewManager.ActionManager.__parentedParent.menu.do_reload_needaction();

It turns out that by embedding the tree view where I did, I need to go through a few layers of __parentedParent to find the __parentedParent that had a menu property.

I've written a short patch that fixes this for me (see attached).

The form definition that exhibits this error:
<?xml version="1.0" encoding="UTF-8"?>
<openerp>
 <data>
  <record id="phonecall_enhancements_res_partner_form_view"
   model="ir.ui.view">
   <field name="name">phonecall.enhancements.res.partner.form</field>
   <field name="model">res.partner</field>
   <field name="type">form</field>
   <field name="inherit_id" ref="base.view_partner_form" />
   <field name="arch" type="xml">
    <data>
     <page string="Internal Notes" position="before">
      <page string="Phone Calls" attrs="{'invisible': [('type','!=', 'default')]}">
       <field name="phonecall_ids" mode="tree" context="{'default_partner_id': active_id}" />
      </page>
     </page>
    </data>
   </field>
  </record>
 </data>
</openerp>

[Stefan Rijnhart (Opener) (stefan-opener)]

Hi Isaac,

can you believe I ran into this bug 10 minutes before you submitted this patch. I confirm that your patch works so I am submitting a merge proposal.

[Xavier (Open ERP) (xmo-deactivatedaccount)]

Looks like this was fixed in revision <email address hidden>

[Stefan Rijnhart (Opener) (stefan-opener)]

Looks like it's fixed indeed. Thanks Xavier!